[Tests-Only] Implement guzzle6 in acceptance tests#36999
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #36999 +/- ##
============================================
- Coverage 64.75% 64.41% -0.34%
Complexity 19138 19138
============================================
Files 1270 1270
Lines 74912 74877 -35
Branches 1329 1329
============================================
- Hits 48507 48231 -276
- Misses 26014 26255 +241
Partials 391 391
Continue to review full report at Codecov.
|
phil-davis
force-pushed
the
use-guzzle6-for-acceptance-tests
branch
from
f074c04 to
2336aa8
Compare
This was referenced Feb 21, 2020
Closed
individual-it
approved these changes
Feb 24, 2020
delete-merged-branch
Bot
deleted the
use-guzzle6-for-acceptance-tests
branch
This was referenced Feb 24, 2020
This was referenced Feb 24, 2020
This was referenced Feb 24, 2020
This was referenced Feb 24, 2020
This was referenced Feb 24, 2020
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
These acceptance test changes have been taken from old Guzzle PR #32537 and then worked on to work in the current core master. One of the main things to re-engineer was the "batch mode" creation of users by the acceptance tests. That had been added in master using Guzzle5 batch features, which changed for Guzzzle6.
This is a squashed version of PR #36946 - I left that PR with 12 commits just in case I need to go back and pick out parts of the changes that I did along the way getting this to work.
The main things here are:
vendor-bin/behat/composer.jsonchangeguzzlehttp/guzzlefrom5.3to6.5When this is merged, the apps will also need to use guzzle6 with behat for acceptance tests. So every app that has acceptance tests will need to have guzzle changed to 6.5 in
vendor-bin/behat/composer.json- therefore the timing of the core merge here needs to be done when we can straight away submit the needed app PRs.owncloud/activity#837 contains a demonstration that it works for the
activityapp.Related Issue
How Has This Been Tested?
CI and lots of local acceptance test runs
Types of changes
Checklist: