[7.0.5] LDAP user can not be deleted.

[cdamken]

Expected behavior:

Erase LDAP user and the user does not appear, the data folder is erased and the user does not appear in any groups.

Actual behavior:

Erase LDAP user and the user does not appear, the data folder still exist and the user appears in the groups.

Architecture

oC7.0.5
php 5.4
Ubuntu 14.04

LDAP configuration:

S3-ownCloud\Shared\owncloud\support\github-issues\core\16588

@MorrisJobke

00003201

[MorrisJobke]

This only happens when the username is different from the user folder name. (i.e. when you specified the home folder naming rule in the LDAP app)

Reason:

User gets deleted and afterwards the users folder is fetched in

core/lib/private/user/user.php

Line 190 in 7385b5d

\OC_Helper::rmdirr(\OC_User::getHome($this->uid));

-> then the user is already deleted and the fallback of folder name is used in there: https://github.com/owncloud/core/blob/7385b5dad949e95786a54f56d39ea14f21057369/lib/private/user.php#L574-574

I tried the following, but didn't have the time yet to verify if this works:

diff --git a/lib/private/user/user.php b/lib/private/user/user.php
index 28b66d7..e1ee4aa 100644
--- a/lib/private/user/user.php
+++ b/lib/private/user/user.php
@@ -174,6 +174,9 @@ class User implements IUser {
                if ($this->emitter) {
                        $this->emitter->emit('\OC\User', 'preDelete', array($this));
                }
+               // homeDir needs to be retrieved before the user is deleted - otherwise it isn't correct and the fallback is used
+               $homeDir = \OC_User::getHome($this->uid);
+
                $result = $this->backend->deleteUser($this->uid);
                if ($result) {

@@ -187,7 +190,7 @@ class User implements IUser {
                        \OC::$server->getConfig()->deleteAllUserValues($this->uid);

                        // Delete user files in /data/
-                       \OC_Helper::rmdirr(\OC_User::getHome($this->uid));
+                       \OC_Helper::rmdirr($homeDir);

                        // Delete the users entry in the storage table
                        \OC\Files\Cache\Storage::remove('home::' . $this->uid);

[MorrisJobke]

For the group issue we need to have an additional look why the group memberships aren't updated. Maybe a caching issue.

[cdamken]

@MorrisJobke I have another case:

00002761

Where the username and folder are the same, but still does not delete the folders:

Full text in: S3-ownCloud\Shared\owncloud\support\github-issues\core\16588\00002761.txt

[MorrisJobke]

I will have a look at this today or tomorrow

[blizzz]

@cdamken

the data folder still exist and the user appears in the groups.

The data folder removal is fixed in #16890 but can you elaborate on the group thing?

[pako81]

I am following this up. Regarding the group issue, Customer wrote:

"Here's the output of the OCC tool, which works now. The User Heinrich has been removed from the ownCloud LDAP Group months ago.

root@atldwosx015:/var/www/owncloud# sudo -u www-data php occ ldap:check-user
Heinrich

The user is still available on LDAP. What can we do to get this working?"

Thus group assignments are not removed upon cleanup.

[blizzz]

@cdamken @pako81 can you check whether #16890 fixes the issue?