the user is gone, userExists will not bring him back. But the user's …#16890
Merged
Conversation
…folder needs to be deleted anyway
This was referenced Jun 11, 2015
Member
|
@blizzz is this ready to review? Has the developing label attached - confudes 😕 - THX |
Contributor
|
Tested and works 👍 |
…leted subsequently
|
A new inspection was created. |
Contributor
Author
|
@DeepDiver1975 Added unit test, now we are good. @jvillafanez @davitol mind testing? |
Contributor
Author
|
or @cdamken |
Contributor
Known problem AFAIK - cc @DeepDiver1975 |
|
🚀 Test PASSed.🚀 |
Member
|
I've followed the next steps:
After all these steps, the user data is removed from ownCloud. 👍 |
DeepDiver1975
added a commit
that referenced
this pull request
Jun 18, 2015
the user is gone, userExists will not bring him back. But the user's …
Contributor
|
@blizzz To which version should this be backported? stable8 and stable7? #16588 was reported on stable7 cc @karlitschek for the approval |
Contributor
Author
|
Yes, to both 7 and 8. |
Contributor
|
@MorrisJobke Backport is fine with me. |
Contributor
|
@blizzz Can you create the backport PRs? |
blizzz
added a commit
that referenced
this pull request
Jun 18, 2015
the user is gone, userExists will not bring him back. But the user's folder needs to be deleted anyway delete user test to take getHome into account to ensure it is also deleted subsequently
blizzz
added a commit
that referenced
this pull request
Jun 18, 2015
the user is gone, userExists will not bring him back. But the user's folder needs to be deleted anyway delete user test to take getHome into account to ensure it is also deleted subsequently Conflicts: apps/user_ldap/tests/user_ldap.php
Contributor
Author
MorrisJobke
added a commit
that referenced
this pull request
Jun 23, 2015
Backport of #16890 to stable8
MorrisJobke
added a commit
that referenced
this pull request
Jun 23, 2015
Backport of #16890 to stable7
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…folder needs to be deleted anyway
Fixes #16588 (see #16830 (comment) for what's going in).
@MorrisJobke i keep this wip to consider whether unit test is possible. the exisiting ones work either way.Done.