Revert "adjust to nested group fix - #19821
Merged
3 commits merged intoOct 16, 2015
Merged
Conversation
Contributor
|
Tested by @davitol, see #19818 (comment) |
Contributor
Author
|
Let me try to write some unit tests as well. |
Contributor
|
👍 |
LukasReschke
force-pushed
the
GreenArchon-fix-memberof-regression
branch
from
October 16, 2015 08:36
3ca9110 to
342667b
Compare
LukasReschke
force-pushed
the
GreenArchon-fix-memberof-regression
branch
from
October 16, 2015 08:37
342667b to
d486949
Compare
Contributor
Author
|
Unit tests have been adjusted to catch this situation. |
|
@MorrisJobke review please so we can merge? |
Contributor
|
Tested and works 👍 |
ghost
pushed a commit
that referenced
this pull request
Oct 16, 2015
…ession Revert "adjust to nested group fix
Contributor
|
This PR was to master. |
Contributor
|
@karlitschek we need to backport this |
Contributor
|
stable8.2 PR: #19867 |
Contributor
|
yes .please backport. |
Contributor
|
Thx for taking care for it. Although rather then just reverting I would love to find out why the original change was not working and fixing this to avoid the additional readAttributes call. Anyway, I will look into it later – right now it is not overly urgent as the regression is banned – thank you! |
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit 845485c, which fixes #19816 regression.
Replaces #19818