Skip to content

[stable8.1] allow an attribute to return more than one value - #19972

Merged
MorrisJobke merged 13 commits into
stable8.1from
stable8.1-backport-19635
Oct 27, 2015
Merged

[stable8.1] allow an attribute to return more than one value#19972
MorrisJobke merged 13 commits into
stable8.1from
stable8.1-backport-19635

Conversation

@MorrisJobke

Copy link
Copy Markdown
Contributor

Backport of #19635 (on top of #19427)

cc @blizzz @DeepDiver1975 @karlitschek

@karlitschek

Copy link
Copy Markdown
Contributor

please backport 👍

@MorrisJobke

Copy link
Copy Markdown
Contributor Author

I tested this and there were no errors in the logs 👍

Before merging this I would really like to have @blizzz a look at this.

@davitol Can you test this nevertheless?

@GreenArchon

Copy link
Copy Markdown
Contributor

c1953f9 includes the commit that caused #19816 regression, so you might want to add #19821 on top of it

@MorrisJobke

Copy link
Copy Markdown
Contributor Author

c1953f9 includes the commit that caused #19816 regression, so you might want to add #19821 on top of it

@GreenArchon Thanks for the hint :)

I added them and all still works here.

@MorrisJobke

Copy link
Copy Markdown
Contributor Author

Okay ... then I need the test for this by @davitol here ;)

@blizzz

blizzz commented Oct 27, 2015

Copy link
Copy Markdown
Contributor

I tested this a bit and have seen no issues yet, so plus 👍

However, most of the commits are mine anyway, so more different eyes and testers are more than welcome, @davitol @GreenArchon, maybe also @PeteSSS @plastilincheg ?

@davitol

davitol commented Oct 27, 2015

Copy link
Copy Markdown
Contributor

@MorrisJobke @blizzz I am testing it right now and I could not find any issue yet too, so from my POW 👍

MorrisJobke added a commit that referenced this pull request Oct 27, 2015
[stable8.1] allow an attribute to return more than one value
@MorrisJobke
MorrisJobke merged commit 3387d05 into stable8.1 Oct 27, 2015
@MorrisJobke
MorrisJobke deleted the stable8.1-backport-19635 branch October 27, 2015 13:08
@ghost ghost removed the in progress label Oct 27, 2015
@MorrisJobke

Copy link
Copy Markdown
Contributor Author

3 working tests -> merged

@lock

lock Bot commented Aug 6, 2019

Copy link
Copy Markdown

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock Bot locked as resolved and limited conversation to collaborators Aug 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants