Remove unnecessary group name validation in provisioning_api - #20961
Conversation
|
By analyzing the blame information on this pull request, we identified @LukasReschke, @rullzer and @owncloud-bot to be potential reviewers |
There was a problem hiding this comment.
Now that's what I was looking for!
There was a problem hiding this comment.
I guess this is simple enough. We just need to make sure proper tests are run on the group manager.
1f8a0b1 to
cfb8ec5
Compare
|
Rebased and fixed the unit test (trivial). |
cfb8ec5 to
b4e9478
Compare
rullzer
changed the title
There was a problem hiding this comment.
update the error message ?
|
👍 |
3275974 to
3327857
Compare
|
I rebased on a more recent commit to trigger the tests again ;) |
|
👍 Works fine. Just a question, no character has to be forbidden in group names? |
Remove unnecessary group name validation in provisioning_api
|
@SergioBertolinSG that part should be handled in the GroupManager... so if chars are forbidden they should be forbidding in all code paths. |
|
This needs to be backported to stable8.2. |
|
"needs" as in: for API consistency but also to make integration tests pass there |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
7 participants
Fixes #20817 by removing the unnecessary group name validation that is not present elsewhere in ownCloud - allows the full range of characters.
WIP as I need to fix my env so I can check the tests.