Skip to content

Stable8.2 provis api group special char - #25477

Closed
SergioBertolinSG wants to merge 4 commits into
stable8.2from
stable8.2-provis-api-group-special-char
Closed

Stable8.2 provis api group special char#25477
SergioBertolinSG wants to merge 4 commits into
stable8.2from
stable8.2-provis-api-group-special-char

Conversation

@SergioBertolinSG

Copy link
Copy Markdown
Contributor

Backport of #20961

Please review @DeepDiver1975 @PVince81

@mention-bot

Copy link
Copy Markdown

@SergioBertolinSG, thanks for your PR! By analyzing the annotation information on this pull request, we identified @LukasReschke, @rullzer and @tomneedham to be potential reviewers

@PVince81

Copy link
Copy Markdown
Contributor

Moving to 8.2.8 as we're post RC1

@PVince81 PVince81 modified the milestones: 8.2.7, 8.2.8 Jul 14, 2016
@SergioBertolinSG

Copy link
Copy Markdown
Contributor Author

OCA\Provisioning_API\Tests\GroupsTest::testAddGroupEmptyGroup
Undefined property: OCA\Provisioning_API\Groups::$request

This will need a different approach.

@PVince81

Copy link
Copy Markdown
Contributor

If it is too complicated I suggest to not backport this as it's not really critical.

@SergioBertolinSG

Copy link
Copy Markdown
Contributor Author

Failing because EEEPHP Fatal error: Call to undefined method OC\Group\Manager::method() in /ssd/jenkins/workspace/core-ci-linux-php5.4/database/sqlite/label/SLAVE/apps/provisioning_api/tests/groupstest.php on line 262

@PVince81

Copy link
Copy Markdown
Contributor

@SergioBertolinSG I suggest closing this. There are more important tests to work on.

@SergioBertolinSG

Copy link
Copy Markdown
Contributor Author

Yes, I agree.

@PVince81
PVince81 deleted the stable8.2-provis-api-group-special-char branch January 12, 2017 08:54
@lock

lock Bot commented Aug 4, 2019

Copy link
Copy Markdown

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock Bot locked as resolved and limited conversation to collaborators Aug 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants