DAV now returns file name with Content-Disposition header

[PVince81]

Fixes issue where Chrome would append ".txt" to XML files when downloaded in the web UI

Fixes #23176

Please review @owncloud/filesystem @DeepDiver1975 @nickvergessen @rullzer

Would be best to backport this to 9.0 because that's where the issue first appeared, at the time where we switched the web UI to use the Webdav endpoint for downloads.

CC @DeepDiver1975 @dragotin

[mention-bot]

By analyzing the blame information on this pull request, we identified @rullzer, @DeepDiver1975 and @nickvergessen to be potential reviewers

[PVince81]

• TEST: old dav endpoint still works (since we touched FilesPlugin)
• TEST: new dav endpoint still works (since we touched FilesPlugin)
• TEST: downloading an XML file with chrome properly returns an XML file

[guruz]

👍

[rullzer]

why this dark magic? That is going to bite us at some point...

[nickvergessen]

It's copied from Sabre\Auth,

don't know if it really is that dark, seems like the only way

[rullzer]

ok fair enough...

[icewind1991]

Looks good 👍

[rullzer]

Should we have intergration tests for this?

[rullzer]

O and failing intergration tests:

06:38:18
06:38:18 --- Failed scenarios:
06:38:18
06:38:18 /var/lib/jenkins/jenkins-slave/workspace/ocs-api-integration-tests-ci@2/build/integration/features/webdav-related.feature:80
06:38:18 /var/lib/jenkins/jenkins-slave/workspace/ocs-api-integration-tests-ci@2/build/integration/features/webdav-related.feature:95
06:38:18

[PVince81]

Ok, I'll have a look. Thanks

[PVince81]

Fixed the integration test, glad that it exists 😄

[rullzer]

👍

[PVince81]

stable9: #25052

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.