Skip to content

[stable9] DAV now returns file name with Content-Disposition header - #25052

Merged
PVince81 merged 1 commit into
stable9from
stable9-webdav-download-mimetype
Jun 15, 2016
Merged

[stable9] DAV now returns file name with Content-Disposition header#25052
PVince81 merged 1 commit into
stable9from
stable9-webdav-download-mimetype

Conversation

@PVince81

Copy link
Copy Markdown
Contributor

That was a tough backport of #25043 to stable9 due to many conflicts.

Please review and test @owncloud/filesystem @DeepDiver1975 @nickvergessen @rullzer @guruz

Sync client download, cadaver download and Chromium download worked properly.

@PVince81 PVince81 added this to the 9.0.3-current-maintenance milestone Jun 10, 2016
@PVince81
PVince81 force-pushed the stable9-webdav-download-mimetype branch from 4a85018 to a533cde Compare June 10, 2016 14:14
@nickvergessen

Copy link
Copy Markdown
Contributor

That was a tough backport of #25043 to stable9 due to many conflicts.

still looks good ;)

However, integration tests failed due to network issues:

[Composer\Downloader\TransportException]
The "https://packagist.org/packages.json" file could not be downloaded: failed to open stream: Connection timed out

since you touched them, I guess it would be nice to rebase (just to be sure)

@PVince81
PVince81 force-pushed the stable9-webdav-download-mimetype branch from a533cde to 81761b8 Compare June 13, 2016 08:50
@PVince81

Copy link
Copy Markdown
Contributor Author

Rebased

@PVince81

Copy link
Copy Markdown
Contributor Author

I just ran the webdav feature tests locally and they went fine.

25 scenarios (25 passed)
157 steps (157 passed)

Seems that the OCS int executor still has timeout troubles. CC @DeepDiver1975

Still need two thumbs up to get this merged.

@PVince81

Copy link
Copy Markdown
Contributor Author

To test:

  1. Upload a file "test.jpg" to ownCloud
  2. curl -D - -X GET http://localhost/owncloud/remote.php/webdav/test.jpg
  3. Check the "Content-Disposition" header

Before: no filename part
After: filename part is there

Then for the Chrome bug, see #23176
Basically upload a "test.xml" file and download it in the Chromium web UI. Chromium would save it as "test.txt" instead of "test.xml".

@nickvergessen

Copy link
Copy Markdown
Contributor

works fine by me, but even before.
But nothing broke and the header is good, so 👍

@rullzer

rullzer commented Jun 15, 2016

Copy link
Copy Markdown
Contributor

Header is set here 👍

@PVince81
PVince81 merged commit 3da5d06 into stable9 Jun 15, 2016
@PVince81
PVince81 deleted the stable9-webdav-download-mimetype branch June 15, 2016 13:27
@lock

lock Bot commented Aug 5, 2019

Copy link
Copy Markdown

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock Bot locked as resolved and limited conversation to collaborators Aug 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants