[9.2] Adding Open Graph Support for public shares http://ogp.me/

[DeepDiver1975]

Sharing a image where a preview can be generated:

Sharing a PDF where no preview is available an we fallback to the logo

[mention-bot]

@DeepDiver1975, thanks for your PR! By analyzing the annotation information on this pull request, we identified @LukasReschke, @lenz1111 and @rullzer to be potential reviewers

[tcitworld]

May there be a default og:image even if we have no preview (like the oC logo) or is it a bad practice to provide a picture that doesn't indicate content ?

[DeepDiver1975]

May there be a default og:image even if we have no preview (like the oC logo)

sounds reasonable to me

[DeepDiver1975]

@wotanii please help testing this - thx

[bjuergens]

Short:

I suggest you adjust preview-sizes, so the default-preview has about the same size as the preview for a big image. The relevant og-tags are: og:image:width and og:image:height

Long:

I don't really know what to test, so I changed my instance of owncloud 8.2.7 to include this PR.

• I moved all changes to public.php. It now look like this
• I shared some links:
  • password-protected: https://owncloud.wotanii.de/index.php/s/h5MyR1RUfG6AEV3/authenticate
  • pdf file: https://owncloud.wotanii.de/index.php/s/2N6pV82xi6FCD3r#pdfviewer
  • jpg: https://owncloud.wotanii.de/index.php/s/Q42PHXkSBW8x28P
• and when you send them via telegram, those links look like this:
  

So everything seems to work fine. Although I'm not sure what the deal with $shareTmpl['shareUrl']is. I left it out in my "backport", because I don't really see why it's there in the first place.

edit:
here is the same chat as seen from a android-device:

As you can see the default-image for the pdf-file is big and blurry; and the generated preview for the big JPG is very small.

[PVince81]

Anything left to do here ? From the comments above it seems this works fine ?

[DeepDiver1975]

Ready for final review, test and merge from my pov

[PVince81]

Fixes #12946

[PVince81]

👍

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.