Skip to content

Update public.php#26125

Closed
bjuergens wants to merge 1 commit into
owncloud:masterfrom
bjuergens:master
Closed

Update public.php#26125
bjuergens wants to merge 1 commit into
owncloud:masterfrom
bjuergens:master

Conversation

@bjuergens

Copy link
Copy Markdown

Description

Added open-graph support to share-page:

  • That little share-title is added for all share-links.
  • When a preview can be generated, the little preview-image is also generated.
  • other cases, that open-graph might support (e.g. videos) are not explicitly included.

please be gentle; this is my first time contributing to free sorftware.

Related Issue

#12946

Motivation and Context

In telegram a share-link now looks like this
bildschirmfoto von 2016-09-16 12-12-49
Without this patch, it looks like this:
bildschirmfoto von 2016-09-16 12-16-01

How Has This Been Tested?

It has been tested on 8.2.7, but not on the current version.

Here is a link to in owncloud-instance, that already uses this feature: https://owncloud.wotanii.de/index.php/s/TQsy6hyWaSM3tBP

You can see, that there are the relavant <meta /> tags in markup.

Screenshots (if appropriate):

bildschirmfoto von 2016-09-16 12-12-49

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

added open-graph support
@CLAassistant

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

@mention-bot

Copy link
Copy Markdown

@wotanii, thanks for your PR! By analyzing the annotation information on this pull request, we identified @Henni, @LukasReschke and @jancborchardt to be potential reviewers

@DeepDiver1975

Copy link
Copy Markdown
Member

There is already an open pull request - please help testing #25579

@lock

lock Bot commented Aug 4, 2019

Copy link
Copy Markdown

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock Bot locked as resolved and limited conversation to collaborators Aug 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants