Fix subadmin permission check for addToGroup/removeFromGroup#25788
Merged
Conversation
Fixes issue where subadmins could never add users to a group. Added missing unit tests
Contributor
Author
|
@SergioBertolinSG do we have integration tests for the provisioning API ? If not, would you mind adding some ? |
Member
|
👍 |
Contributor
Author
|
QA ticket for automated tests: owncloud/QA#290 |
This was referenced Aug 15, 2016
Contributor
Author
|
Updated OP with backport tickets |
This was referenced Oct 10, 2016
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes issue where subadmins could never add users to a group.
Added missing unit tests
Fixes #25496
Please review @DeepDiver1975 @tomneedham @SergioBertolinSG @VicDeo @butonic