[stable9.1] Fix subadmin permission check for addToGroup/removeFromGroup#25797
Merged
PVince81 merged 1 commit intoAug 16, 2016
Merged
Conversation
Fixes issue where subadmins could never add users to a group. Added missing unit tests
Contributor
Author
| * @param IGroup|null $group group to check or null | ||
| * | ||
| * @return true if the user can manage the group | ||
| */ |
Member
There was a problem hiding this comment.
Not really needed due to this function is private, but setting $group as null by default would be nicer. Moreover, I find confusing why a group is needed: a comment in the docs would be nice.
Contributor
Author
There was a problem hiding this comment.
the groupis needed for the isSubadminofGroup call below.
Basically this function is just a helper to check permissions with a shortcut in case the user is an admin to avoid additional checks.
Member
|
👍 |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #25788 to stable9.1
Please review @DeepDiver1975 @tomneedham @SergioBertolinSG @VicDeo @butonic