[stable9.1] Properly convert OCS params + more tests

[PVince81]

Backport of #26691 to stable9.1

Retested manually, still works. (it's covered by int tests though)

@jvillafanez @DeepDiver1975 @SergioBertolinSG

[mention-bot]

@PVince81, thanks for your PR! By analyzing the history of the files in this pull request, we identified @SergioBertolinSG, @rullzer and @MorrisJobke to be potential reviewers.

[jvillafanez]

👍

[PVince81]

Oh no, more test backports needed, @SergioBertolinSG can you help identify which ?

11:49:51     /**
11:49:51      * @Then the response contains :arg1 entries
11:49:51      */
11:49:51     public function theResponseContainsEntries($arg1)
11:49:51     {
11:49:51         throw new PendingException();
11:49:51     }
11:49:51 
11:49:51     /**
11:49:51      * @Then File :arg1 should be included as path in the response
11:49:51      */
11:49:51     public function fileShouldBeIncludedAsPathInTheResponse($arg1)
11:49:51     {
11:49:51         throw new PendingException();
11:49:51     }
11:49:51 
11:49:51     /**
11:49:51      * @Then File :arg1 should not be included as path in the response
11:49:51      */
11:49:51     public function fileShouldNotBeIncludedAsPathInTheResponse($arg1)
11:49:51     {
11:49:51         throw new PendingException();
11:49:51     }
11:49:51 
11:49:51     /**
11:49:51      * @Given user :arg1 stores etag of element :arg2
11:49:51      */
11:49:51     public function userStoresEtagOfElement($arg1, $arg2)
11:49:51     {
11:49:51         throw new PendingException();
11:49:51     }
11:49:51 
11:49:51     /**
11:49:51      * @Then etag of element :arg1 of user :arg2 has changed
11:49:51      */
11:49:51     public function etagOfElementOfUserHasChanged($arg1, $arg2)
11:49:51     {
11:49:51         throw new PendingException();
11:49:51     }
11:49:51 
11:49:51     /**
11:49:51      * @Then etag of element :arg1 of user :arg2 has not changed
11:49:51      */
11:49:51     public function etagOfElementOfUserHasNotChanged($arg1, $arg2)
11:49:51     {
11:49:51         throw new PendingException();
11:49:51     }

[PVince81]

• requires Stable9.1 integration tests adding etag support #26701 for tests to be able to run

[PVince81]

Rebased. Tests should hopefully pass now.

[PVince81]

Uh oh, rebase failure:

13:23:06   Expected Step, but got text: ">>>>>>> Added tests about permissions and public upload" in file: /var/lib/jenkins/workspace/owncloud-core_core_PR-26694-BLDVCEXDEUWCA5MWIA4BU4ICR5DGPZTFWHZXZQC634NNBIIGGNBQ/build/integration/features/sharing-v1.feature 

Will fix...

[PVince81]

And now the other random failures appear again:

15:37:36 1) OCA\Files\Tests\Command\DeleteOrphanedFilesTest::testClearFiles
15:37:36 Expectation failed for method name is equal to <string:writeln> when invoked 1 time(s)
15:37:36 Parameter 0 for invocation Symfony\Component\Console\Output\OutputInterface::writeln('14 orphaned file cache entries deleted', 0) does not match expected value.
15:37:36 Failed asserting that two strings are equal.
15:37:36 --- Expected
15:37:36 +++ Actual
15:37:36 @@ @@
15:37:36 -'4 orphaned file cache entries deleted'
15:37:36 +'14 orphaned file cache entries deleted'
15:37:36 
15:37:36 /var/lib/jenkins/workspace/owncloud-core_core_PR-26694-BLDVCEXDEUWCA5MWIA4BU4ICR5DGPZTFWHZXZQC634NNBIIGGNBQ/apps/files/lib/Command/DeleteOrphanedFiles.php:81
15:37:36 /var/lib/jenkins/workspace/owncloud-core_core_PR-26694-BLDVCEXDEUWCA5MWIA4BU4ICR5DGPZTFWHZXZQC634NNBIIGGNBQ/apps/files/tests/Command/DeleteOrphanedFilesTest.php:119
15:37:36 
15:37:36 2) OCA\Files_Sharing\Tests\CacheTest::testGetFolderContentsInRoot
15:37:36 Failed asserting that 10 matches expected 3.
15:37:36 
15:37:36 /var/lib/jenkins/workspace/owncloud-core_core_PR-26694-BLDVCEXDEUWCA5MWIA4BU4ICR5DGPZTFWHZXZQC634NNBIIGGNBQ/apps/files_sharing/tests/CacheTest.php:444
15:37:36 /var/lib/jenkins/workspace/owncloud-core_core_PR-26694-BLDVCEXDEUWCA5MWIA4BU4ICR5DGPZTFWHZXZQC634NNBIIGGNBQ/apps/files_sharing/tests/CacheTest.php:349
15:37:36 

Probably the env is in a broken state now...

I'll make a new PR for CI...

[PVince81]

#26715

[PVince81]

@SergioBertolinSG seems there is more missing:

17:47:03 --- FeatureContext has missing steps. Define them with these snippets:
17:47:03 
17:47:03     /**
17:47:03      * @Then the response contains :arg1 entries
17:47:03      */
17:47:03     public function theResponseContainsEntries($arg1)
17:47:03     {
17:47:03         throw new PendingException();
17:47:03     }
17:47:03 
17:47:03     /**
17:47:03      * @Then File :arg1 should be included as path in the response
17:47:03      */
17:47:03     public function fileShouldBeIncludedAsPathInTheResponse($arg1)
17:47:03     {
17:47:03         throw new PendingException();
17:47:03     }
17:47:03 
17:47:03     /**
17:47:03      * @Then File :arg1 should not be included as path in the response
17:47:03      */
17:47:03     public function fileShouldNotBeIncludedAsPathInTheResponse($arg1)
17:47:03     {
17:47:03         throw new PendingException();
17:47:03     }

[PVince81]

Not sure if I backported wrong but it seems we backported more sharing tests than necessary. It's not a bad thing. I'll add the missing functions and be done with it. More testing more good!!!

[PVince81]

This env is bust.

Rebooted PR on a new branch: #26716

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.