[stable9.1] Properly convert OCS params + more tests [rebooted]#26716
Merged
Conversation
Added read and share permissions instead of all (default ones) Added positive case Check also permissions update Added tests for resharing with public links when the user doesn't have enough permisssions
Partial backport of the integration tests from #26610
|
@PVince81, thanks for your PR! By analyzing the history of the files in this pull request, we identified @rullzer, @SergioBertolinSG and @LukasReschke to be potential reviewers. |
This was referenced Nov 24, 2016
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #26691 to stable9.1
Retested manually, still works. (it's covered by int tests though)
Reboot of a former backport PR #26694
Approved by @jvillafanez here #26694 (comment)
Jenkins, now do your job