Get user home folder before deletion

[PVince81]

Description

After the deletion getHome() will fail because the user doesn't exist
any more, so we need to fetch that value earlier.

Related Issue

Discovered while looking into #26846

Motivation and Context

How Has This Been Tested?

Fix was tested by applying it on top of #26846.
To test manually, use the MD5 getHome hack from 67dbcdc, then delete a user who has already logged in once.
Before the fix: home folder (md5) is not correctly deleted.
After the fix: home folder (md5) is still deleted.

Screenshots (if appropriate):

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

• My code follows the code style of this project.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I have read the CONTRIBUTING document.
• I have added tests to cover my changes.
• All new and existing tests passed.

Please review @owncloud/qa @butonic @DeepDiver1975 @VicDeo

[mention-bot]

@PVince81, thanks for your PR! By analyzing the history of the files in this pull request, we identified @butonic, @DeepDiver1975 and @bartv2 to be potential reviewers.

[PVince81]

Note that this might not be reproducible in LDAP cases because for LDAP the user is rather deleted from within LDAP. It could happen however than after the LDAP user becomes a "remnant", deleting using occ user:delete will not delete the home folder when LDAP uses the "home directory rule" approach.

Would be good to test that manually too @davitol @SergioBertolinSG

[phisch]

Besides what @PVince81 mentioned about possible LDAP problems: 👍

[DeepDiver1975]

👍

[PVince81]

stable9.1: #27492

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.