Integration test encryption homedir#26844
Conversation
|
@PVince81, thanks for your PR! By analyzing the history of the files in this pull request, we identified @DeepDiver1975, @SergioBertolinSG and @jnweiger to be potential reviewers. |
|
Ouch, many fails even before we even started enabling encryption: It could however be a side-effect. |
|
I made a separate PR where only the home is MD5'd: #26846 |
b74d120 to
03c4ac3
Compare
|
|
I didn't see it finish in my local environment: But I didn't add #26848, is it related? |
|
Let me add that PR here. I hoped we could quickly get #26848 merged and rebase. |
|
also I'd prefer if we could get #26586 merged first which introduces the encryption tests in the first place. |
a0cf8f7 to
50c3e40
Compare
|
Rebased and adjusted. See how the test matrix for integration tests is exploding |
|
Argh, I need to remove the hack commit |
50c3e40 to
1e0bb7b
Compare
|
Fixes owncloud/QA#324 |
|
Now I hope that there is a failing test that matches the scenario from #26820 |
|
Aha, finally some results after running For the first one: and the second one: Now let's see if these pass with #26824 |
|
Yes, the tests from above pass if I cherry-pick the changes from #26824 to this PR. This is what I wanted to cover. |
49ed380 to
ad0c2b6
Compare
|
Fixed the Jenkinsfile to use the correct env variable. @SergioBertolinSG please review this PR. |
There was a problem hiding this comment.
argh, missed this one
ad0c2b6 to
f4ffcdd
Compare
|
#26938 was merged. I have rebased to include it. @SergioBertolinSG rerun all tests locally ? Hopefully they'll all pass now. |
de8c79a to
6b704cc
Compare
|
Test run locally, they worked fine. (Both with encryption and alt home and without). |
6b704cc to
c92ab57
Compare
|
Rebased for CI |
|
WTF, now unrelated unit tests fail
|
|
Reproduceable locally, I'll have a look |
Added filter to disable some tests when encryption is enabled.
c92ab57 to
1bc2364
Compare
|
Removed old bogus encryption fix that we cherry-picked onto this branch for testing but that is obsolete and fixed differently on master. 👍 for @SergioBertolinSG's changes. Let's get this in. |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Extension of #26586 but where the home directory name is different from the user id.
It currently uses a hack to md5 the user's home.
Goal is to reproduce the issue from #26820 automatically.
Let's see how it goes...