Integration tests allowing md5 home#26865
Conversation
|
@SergioBertolinSG, thanks for your PR! By analyzing the history of the files in this pull request, we identified @PVince81, @DeepDiver1975 and @davitol to be potential reviewers. |
| $this->userUploadsAFileTo($user, "work/$filename", $destination); | ||
| $this->removeFile("work/", $filename); | ||
| $userHome = $this->getUserHome($user); | ||
| PHPUnit_Framework_Assert::assertEquals(1, file_exists($userHome . "/files$destination")); |
There was a problem hiding this comment.
I'd still prefer that you use a PROPFIND to make that assert to avoid having to depend on getUserHome.
| $this->userHasAQuotaOf($user, 'none'); | ||
| } | ||
|
|
||
| public function getUserHome($user) { |
There was a problem hiding this comment.
This is not needed for this PR any more, but let's keep it. It will be useful at some point.
Please add PHP doc.
There was a problem hiding this comment.
You mean make it available for behat?
There was a problem hiding this comment.
No, just add a PHPDoc block. This is a public function and might be used elsewhere, so it's a good idea to have a PHPDoc block.
|
Add the missing PHPDoc then it's good to go, thanks! 👍 |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
3 participants
Requirement for #26846 (comment)