Integration tests fixing alt home#26920
Conversation
|
@SergioBertolinSG, thanks for your PR! By analyzing the history of the files in this pull request, we identified @PVince81, @DeepDiver1975 and @davitol to be potential reviewers. |
There was a problem hiding this comment.
with "home" do you mean local folder on the local machine, not ownCloud home ?
This wording is confusing.
There was a problem hiding this comment.
No, I mean owncloud home. User is also an owncloud user.
There was a problem hiding this comment.
This scenario as worded is not possible in a regular ownCloud. You can't upload a file from your ownCloud home. You can upload to your ownCloud home.
I think the reason for this is that you're reading the file directly from inside the data folder to test upload ? You should rather read the file from an external folder containing sample files.
There was a problem hiding this comment.
Also one problem with reading a file directly from the data folder is that in some cases that file could be encrypted, that could break tests.
There was a problem hiding this comment.
OK, then I'll have to change those scenarios.
There was a problem hiding this comment.
Moving the file seems more appropiate.
There was a problem hiding this comment.
I have changed the federation tests, now that part is not needed.
PVince81
left a comment
PVince81
left a comment
There was a problem hiding this comment.
Looks good except for the wording issue
|
Tests using alt home variable have passed. |
SergioBertolinSG
force-pushed
the
integration-tests-fixing-alt-home
branch
from
a9197f2 to
6c2f308
Compare
|
Tests have passed locally after last changes. |
|
Thanks, merging then 👍 I'll then rebase the other PR after that. |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
3 participants
Fixing the problems found in #26918
Running tests locally, will add output after they finish.