Ignore exception when deleting keys of deleted user#26968
Merged
Conversation
added 2 commits
January 18, 2017 17:02
This reverts commit 4559dad.
Whenever a user was deleted for encryption where the keys are stored in the home, we can ignore user existence exceptions because it means the keys are already gone.
|
@PVince81, thanks for your PR! By analyzing the history of the files in this pull request, we identified @DeepDiver1975 to be a potential reviewer. |
This was referenced Jan 18, 2017
Member
|
Other than logging something in case the user isn't found, the rest looks good 👍 |
Contributor
Author
|
It's not a good idea to log here because there will be a log for every user deletion then and it will spam the log, might be interpreted as a problem by admins. |
Member
|
Hmmm, you have a point. Maybe we should think about how to improve the logging in order to trace what's happening without spamming the log file too much (outside of this PR's scope, obviously) |
9 tasks
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Reverts #26938 and provides an alternative solution.
Whenever a user was deleted for encryption where the keys are stored in the home, we can ignore user existence exceptions because it means the keys are already gone.
Related Issue
See #26824 (comment)
and #26935
Motivation and Context
How Has This Been Tested?
Enable encryption with or without "alternative home" mode.
Create then delete a user.
Before this fix:
After this fix: no exception in both modes.
Screenshots (if appropriate):
Types of changes
Checklist:
@jvillafanez please review