Skip to content

[stable9.1] Integration test check download without saving file locally#27077

Merged
PVince81 merged 1 commit into
stable9.1from
stable9.1-inttest-checkurlwithoutsaveto
Feb 6, 2017
Merged

[stable9.1] Integration test check download without saving file locally#27077
PVince81 merged 1 commit into
stable9.1from
stable9.1-inttest-checkurlwithoutsaveto

Conversation

@PVince81

@PVince81 PVince81 commented Feb 3, 2017

Copy link
Copy Markdown
Contributor

Backport of #27008 to stable9.1

@SergioBertolinSG please approve

Use Guzzle stream mode to download the contents instead of using a
temporary local file.
@mention-bot

Copy link
Copy Markdown

@PVince81, thanks for your PR! By analyzing the history of the files in this pull request, we identified @LukasReschke, @nickvergessen and @rullzer to be potential reviewers.

@PVince81

PVince81 commented Feb 3, 2017

Copy link
Copy Markdown
Contributor Author

related sharing test passes for me here: sudo -uwwwrun ./run.sh features/sharing-v1.feature:44

@SergioBertolinSG
SergioBertolinSG self-requested a review February 3, 2017 12:07
@PVince81
PVince81 merged commit d34ad6b into stable9.1 Feb 6, 2017
@PVince81
PVince81 deleted the stable9.1-inttest-checkurlwithoutsaveto branch February 6, 2017 14:33
@lock

lock Bot commented Aug 4, 2019

Copy link
Copy Markdown

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock Bot locked as resolved and limited conversation to collaborators Aug 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants