Reload file list when leaving hidden state#27703
Merged
Merged
Conversation
Whenever a file list is already initialized and was hidden when switching to another file list in the navigation bar, if the user comes back to this list it gets redisplayed. At this point the list needs to be refreshed to be able to reflect any potential file changes done from the other lists.
Member
|
I don't expect any dangerous thing happening if we reload twice or more other than more network traffic, so I think it's fine 👍 |
Contributor
Author
|
I checked the network traffic and it only re-requests the contents once. The reason is that even though the |
Contributor
Author
|
Apparently now the file list is always loaded twice... once for the "show" event and once for the "urlChanged"... 😞 |
Contributor
Author
|
raised as regression here #27890 |
9 tasks
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Whenever a file list is already initialized and was hidden when
switching to another file list in the navigation bar, if the user comes
back to this list it gets redisplayed. At this point the list needs to
be refreshed to be able to reflect any potential file changes done from
the other lists.
Related Issue
Fixes #27697
Motivation and Context
See description and ticket
How Has This Been Tested?
See ticket steps
Screenshots (if appropriate):
Types of changes
Checklist:
Please review @jvillafanez @noveens