Only reload file list when switching navigation sections#28804
Merged
Conversation
added 2 commits
August 25, 2017 16:45
This was referenced Aug 25, 2017
Contributor
|
👍 |
Contributor
|
Fixes the "flashing load" of the home folder, before then displaying the sub-folder content. |
phil-davis
approved these changes
Aug 29, 2017
phil-davis
left a comment
Contributor
There was a problem hiding this comment.
Approving because it works. Would be another fix of an annoying little thing that can be got into the next beta maybe.
Contributor
Author
|
stable10: #28843 |
Contributor
|
yay nice. I was annoyed this breaks the scrollTo private linkls.. hope this fixes it |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Reverts a previous bad fix from #27703 which causes a double reload and even breaks sometimes when opening a private link by reloading the wrong list.
Adds a better fix that only reloads a file list whenever the active navigation section has changed, because that's when we need to refresh, for example after restoring a file from trash, the "All files" list needs to refresh to display the restored folder.
Also prevents initial double reload of the file list.
Related Issue
Fixes #27890
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: