Skip to content

Keep redirect_url on failed auth#28255

Merged
DeepDiver1975 merged 2 commits into
masterfrom
keep-redirect-on-failed-auth
Jul 27, 2017
Merged

Keep redirect_url on failed auth#28255
DeepDiver1975 merged 2 commits into
masterfrom
keep-redirect-on-failed-auth

Conversation

@butonic

@butonic butonic commented Jun 28, 2017

Copy link
Copy Markdown
Contributor

fixes #28129

@butonic butonic requested a review from ogoffart June 28, 2017 20:48
@phil-davis

phil-davis commented Jun 29, 2017

Copy link
Copy Markdown
Contributor

I was looking at a UI test for this, because we need to make the current UI login tests be able to handle landing on different pages after the login is done (currently they expect to land on the Files page). So this bug seemed an appropriate one to use as a test case.
It is ready - see #28257
Note: also the UI test is backporting to stable10 so it will be there to have the test unskipped when this fix is backported - #28292

@PVince81

Copy link
Copy Markdown
Contributor

@butonic please add unit test

@PVince81 PVince81 added this to the development milestone Jun 29, 2017
@PVince81

PVince81 commented Jul 4, 2017

Copy link
Copy Markdown
Contributor
  • add unit tests
  • rebase
  • unskip the UI test

@DeepDiver1975 DeepDiver1975 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested - works

@lock

lock Bot commented Aug 3, 2019

Copy link
Copy Markdown

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock Bot locked as resolved and limited conversation to collaborators Aug 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Login screen: entering the wrong password breaks the redirect

4 participants