Skip to content

Unskip login redirect test for issue 28129#28514

Merged
PVince81 merged 1 commit into
masterfrom
unskip-for-28129
Jul 31, 2017
Merged

Unskip login redirect test for issue 28129#28514
PVince81 merged 1 commit into
masterfrom
unskip-for-28129

Conversation

@phil-davis

Copy link
Copy Markdown
Contributor

Description

Unskip the previously skipped test that was waiting for issue 28129 to be resolved.

Related Issue

#28129

Motivation and Context

PR #28255 has been merged, which fixes issue #28129
So the related test will now pass, and can be run as part of the regular UI test suite.

How Has This Been Tested?

Run UI login.feature tests locally

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@phil-davis

Copy link
Copy Markdown
Contributor Author

Rebased

@PVince81 PVince81 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@PVince81 PVince81 merged commit 2c3fbdc into master Jul 31, 2017
@PVince81 PVince81 deleted the unskip-for-28129 branch July 31, 2017 07:38
@PVince81

Copy link
Copy Markdown
Contributor

please backport

@phil-davis

Copy link
Copy Markdown
Contributor Author

Backport to stable10 #28538

@lock

lock Bot commented Aug 3, 2019

Copy link
Copy Markdown

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock Bot locked as resolved and limited conversation to collaborators Aug 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants