Skip to content

[Test only] Make a comment change#28300

Closed
phil-davis wants to merge 1 commit into
stable10from
phil-davis-stable10-Jenkins-test
Closed

[Test only] Make a comment change#28300
phil-davis wants to merge 1 commit into
stable10from
phil-davis-stable10-Jenkins-test

Conversation

@phil-davis

Copy link
Copy Markdown
Contributor

to see if Jenkins runs OK by default in stable10

to see if Jenkins runs OK by default in stable10
@phil-davis

Copy link
Copy Markdown
Contributor Author

This Jenkins fail happens here with just making a whitespace edit in a comment. So something is wrong with Jenkins or some code or test committed to stable10.
@PVince81 @SergioBertolinSG ???

@SergioBertolinSG

Copy link
Copy Markdown
Contributor

hmm yes, seems there is a problem with auth.feature:10

08:17:02   ┌─ @BeforeScenario # FeatureContext::prepareParameters()
08:17:02   │
08:17:02   ╳  Failed asserting that '' contains "testing".
08:17:02   │
08:17:02   Scenario: access files app anonymously               # /var/lib/jenkins/workspace/owncloud-core_core_PR-28300-JYFUMONU36ZP3GGYQNOK7L35A3JQLD6FQ4LI4CKVIAVKZ65YKG7Q/tests/integration/features/auth.feature:10

I am thinking about the trashbin tests which requires a log in like using the web ui, maybe it is affecting this test somehow.

@SergioBertolinSG

Copy link
Copy Markdown
Contributor

No, trashbin tests were not merged yet. Actually that PR (#28268) is failing for the same reason.

@SergioBertolinSG

SergioBertolinSG commented Jul 5, 2017

Copy link
Copy Markdown
Contributor

@PVince81 do you know about recent changes in stable10 which could make auth.feature:10 to fail?

https://github.com/owncloud/core/blob/stable10/tests/integration/features/auth.feature#L10-L12

@PVince81

PVince81 commented Jul 5, 2017

Copy link
Copy Markdown
Contributor

@PVince81 do you know about recent changes in stable10 which could make auth.feature:10 to fail?

no

@PVince81

PVince81 commented Jul 5, 2017

Copy link
Copy Markdown
Contributor

bisect ?

@SergioBertolinSG

Copy link
Copy Markdown
Contributor

The test alone doesn't fail locally. It has to run the whole suite. Probably it just requires some particular feature to run before auth.

Maybe we can modify run.sh to get tags as parameters, and add a tag to every feature. In this cases it is useful to be able to run just a couple of features.

@phil-davis

Copy link
Copy Markdown
Contributor Author

This was only to test Jenkins runs - closing.

@phil-davis phil-davis closed this Jul 5, 2017
@phil-davis phil-davis deleted the phil-davis-stable10-Jenkins-test branch July 5, 2017 15:35
@lock

lock Bot commented Aug 3, 2019

Copy link
Copy Markdown

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock Bot locked as resolved and limited conversation to collaborators Aug 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants