Skip to content

[Stable10] inttest adding trashbin scenarios#28268

Merged
PVince81 merged 17 commits into
stable10from
stable10-inttest-adding-trashbin-scenarios
Jul 10, 2017
Merged

[Stable10] inttest adding trashbin scenarios#28268
PVince81 merged 17 commits into
stable10from
stable10-inttest-adding-trashbin-scenarios

Conversation

@SergioBertolinSG

@SergioBertolinSG SergioBertolinSG commented Jun 30, 2017 •
edited
Loading

Copy link
Copy Markdown
Contributor

Backport of #28111
Edit: and backport of #28196

@SergioBertolinSG SergioBertolinSG added this to the development milestone Jun 30, 2017
@SergioBertolinSG SergioBertolinSG changed the title Stable10 inttest adding trashbin scenarios [Stable10] inttest adding trashbin scenarios Jun 30, 2017
PVince81
PVince81 approved these changes Jun 30, 2017
View reviewed changes

@PVince81 PVince81 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@SergioBertolinSG

SergioBertolinSG commented Jun 30, 2017

Copy link
Copy Markdown
Contributor Author

@PVince81 Requires backport of #28196

@SergioBertolinSG SergioBertolinSG force-pushed the stable10-inttest-adding-trashbin-scenarios branch from 6c89efe to 7f2f92f Compare July 3, 2017 08:22
@SergioBertolinSG

SergioBertolinSG commented Jul 3, 2017 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Weird failure on jenkins:

auth.access files app with basic auth

When requesting "/index.php/apps/files" with "GET" using basic auth:

Server error response [url] http://localhost:8100/index.php/apps/files [status code] 500 [reason phrase] Internal Server Error

Locally it passes without problems.

@PVince81

PVince81 commented Jul 4, 2017

Copy link
Copy Markdown
Contributor

@SergioBertolinSG can you rebase once just in case ? If the same error appears again we should dig deeper.

@SergioBertolinSG SergioBertolinSG force-pushed the stable10-inttest-adding-trashbin-scenarios branch from 7f2f92f to 26730cb Compare July 4, 2017 08:52
@PVince81

PVince81 commented Jul 4, 2017

Copy link
Copy Markdown
Contributor

the jenkins needs the boot

@SergioBertolinSG SergioBertolinSG force-pushed the stable10-inttest-adding-trashbin-scenarios branch from 26730cb to 464af13 Compare July 4, 2017 15:19
@SergioBertolinSG SergioBertolinSG mentioned this pull request Jul 5, 2017
Closed
@PVince81

PVince81 commented Jul 5, 2017

Copy link
Copy Markdown
Contributor 
19:50:10 --- Skipped scenarios:
19:50:10 
19:50:10     /var/lib/jenkins/workspace/owncloud-core_core_PR-28268-RS56ERDLELP5YGB6S6XY4BWH23KEIBTL6KWMLKOZ5SELCGDK3S5Q/tests/integration/features/auth.feature:10

@SergioBertolinSG SergioBertolinSG force-pushed the stable10-inttest-adding-trashbin-scenarios branch from 464af13 to 9ff9ec7 Compare July 5, 2017 15:16
@SergioBertolinSG

SergioBertolinSG commented Jul 6, 2017

Copy link
Copy Markdown
Contributor Author

Now it is needing #28310 .

@SergioBertolinSG SergioBertolinSG mentioned this pull request Jul 6, 2017
Merged
@SergioBertolinSG
Added test about deleting folder
8464ac3
@SergioBertolinSG
Added more scenarios to trashbin
7ff272a
@SergioBertolinSG
Added more scenarios
1e46b58
@SergioBertolinSG
Added cases for new endpoint, emptying the trashbin and recover files…
9e61e47 
… (not working yet)
@SergioBertolinSG
Included needed functionality to trashbin trait
2438836
@SergioBertolinSG
Making the deleted files names like in https://github.com/owncloud/co…
1fd827d 
…re/blob/master/apps/files_trashbin/js/filelist.js#L106
@SergioBertolinSG
With this change it works when disabling the csrf check
ae584d7
@SergioBertolinSG
Changed the way direct requests handle requestToken and used logging …
8501e0e 
…as web since trashbin requires it
@SergioBertolinSG
Added some corrections
ecfeba1
@SergioBertolinSG
Added tests cases using external storage
c604446
@SergioBertolinSG
Files are not detected because they were removed in the file system a…
ac7352e 
…nd never scanned
@SergioBertolinSG
Added skip tag to be able to merge failing tests and allow developers…
e6d1807 
… to run the tests afterwards
@SergioBertolinSG SergioBertolinSG force-pushed the stable10-inttest-adding-trashbin-scenarios branch from 9ff9ec7 to 036657e Compare July 7, 2017 11:53
@PVince81 PVince81 merged commit d987a38 into stable10 Jul 10, 2017
@PVince81 PVince81 deleted the stable10-inttest-adding-trashbin-scenarios branch July 10, 2017 07:58
@lock

lock Bot commented Aug 3, 2019

Copy link
Copy Markdown

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock Bot locked as resolved and limited conversation to collaborators Aug 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
@PVince81 PVince81 PVince81 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

4 - To release dev:integration-tests status/STALE

Projects

None yet

Milestone

10.0.3

Development

Successfully merging this pull request may close these issues.

3 participants

@SergioBertolinSG @PVince81 @ownclouders