do not cache logger when running unit tests#28313
Merged
Merged
Conversation
Member
Author
|
after this fix unit tests of firewall app are passing again locally and on travis |
Contributor
|
@aneumann IMHO this PR doesn't look like the best approach to solve the tests problem... No idea how to fix them, but I guess adding code related to tests in server.php is not a good idea. |
Contributor
|
I don't have any better idea. @individual-it can you add a PHP comment to explain why this change is needed ? |
individual-it
force-pushed
the
fix-logger-phpunit
branch
from
8d9a287 to
2b36e07
Compare
Member
Author
|
@PVince81 does this comment make it understandable what happens? |
phil-davis
reviewed
Jul 10, 2017
Contributor
There was a problem hiding this comment.
except then? or except when
individual-it
force-pushed
the
fix-logger-phpunit
branch
from
2b36e07 to
2b59091
Compare
Contributor
|
@PVince81 @DeepDiver1975 @individual-it |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
when running unit tests the logger should not be cached to make it possible to mock it
Related Issue
file firewall unit tests were failing after #28215
Screenshots (if appropriate):
travis run on firewall tests before fix
Types of changes
Checklist: