Improve file upload progress bar#28842
Conversation
Only hide at the end of all chunked transfers. Display "Processing files..." when stalled at 100% (final move, antivirus, etc)
|
@VicDeo please review and also test with antivirus. The delay doesn't care what is delaying, it just checks if we are stalled at 100%. |
PVince81
added
the
p2-high
| if (this._progressBarInterval) { | ||
| window.clearInterval(this._progressBarInterval); | ||
| } | ||
| this._progressBarInterval = window.setInterval(_.bind(this._updateProgressBar, this), 1000); |
There was a problem hiding this comment.
I'd rather move this progress bar handling to another class. This way we can extract these superfluous attributes from the upload object.
If time is pressuring, it's fine to leave it as technical debt since the usage of those attributes isn't spread.
There was a problem hiding this comment.
At first I started moving this to a new class then I realized that it would be too many changes at once, so I reverted to this disappointedly ugly solution.
jvillafanez
left a comment
jvillafanez
left a comment
There was a problem hiding this comment.
Code looks fine, not tested.
|
stable10: #28861 |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
3 participants
Description
Only hide at the end of all chunked transfers.
Display "Processing files..." when stalled at 100% (final move,
antivirus, etc)
Related Issue
None
Motivation and Context
People complain about the progress bar being stuck at 100% for a while at the end of the transfer.
Since we don't have any way to detect progress past bytes transfer, this changes the message to make it look like something is still happening.
How Has This Been Tested?
Prepare 5 local 100 MB files. Upload them all in one batch. Observe progress bar.
Before the fix: progress bar disappears too early after the first file is done.
After the fix: progress bar stays until the end of the party and 🍸 a bit longer displaying "Processing files..."
Screenshots (if appropriate):
Types of changes
Checklist:
@pmaier1 @cdamken FYI