Fix getting drop target when dragging from file manager by PVince81 · Pull Request #28692 · owncloud/core

PVince81 · 2017-08-15T10:48:47Z

Description

Possibly related to jquery.fileupload upgrade, now
e.originalEvent.target might be null.

Related Issue

Fixes #28689.

Motivation and Context

See ticket

How Has This Been Tested?

Manual testing like in the ticket.

Screenshots (if appropriate):

Types of changes

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

My code follows the code style of this project.
My change requires a change to the documentation.
I have updated the documentation accordingly.
I have read the CONTRIBUTING document.
I have added tests to cover my changes.
All new and existing tests passed.

jvillafanez · 2017-08-31T08:34:26Z

 				}

-				var dropTarget = $(e.originalEvent.target);
+				var dropTarget = $(e.originalEvent.target || e.originalEvent.delegatedEvent.target);


I guess the e.original.target won't be needed any longer.

The change in the library that affects this is

core/apps/files/js/jquery.fileupload.js

Line 1137 in 639dafd

if (that._trigger('drop', e, data) !== false) {

(before the library update) and https://github.com/owncloud/core/blob/master/apps/files/js/jquery.fileupload.js after the library update.
The actual event isn't set as the originalEvent but as the delegateEvent.

Unless we want compatibility between the library versions, which I don't think it's needed, we can remove the old code.

Thanks for looking deeper. To be honest I was just too lazy to investigate this detail.

@jvillafanez adjusted

SergioBertolinSG · 2017-08-31T08:55:46Z

BUG: When uploading several files to a folder there is no uploading bar. => fixed by rebasing (Improve file upload progress bar #28842)

SergioBertolinSG · 2017-08-31T08:57:18Z

BUG: When uploading a folder with several folders and files inside them into a subdirectory of the current view, the files are not uploaded.

PVince81 · 2017-08-31T09:00:51Z

~~stable10: owncloud/notifications#117~~

jvillafanez · 2017-08-31T11:05:32Z

Wrong link? Backport doesn't seem related.

PVince81 · 2017-08-31T11:08:32Z

oh lala, major browser tab fail. I'll fix

jvillafanez · 2017-08-31T11:26:30Z

When uploading a folder with several folders and files inside them, the files are not uploaded.

Folder upload seems to be be supported only in chrome. It's very likely a browser limitation.

SergioBertolinSG · 2017-08-31T11:33:46Z

Using chrome I mean.

PVince81 · 2017-08-31T12:57:19Z

BUG: progress bar does not disappear when uploading a folder (chrome) into the current dir

PVince81 · 2017-08-31T13:24:33Z

BUG: target row size must be refreshed after transfer to have the correct size => Refresh file list row after upload into subfolder #28873

I had a look at this and it's more complex, to be fixed separately. This is not related to the jquery.fileupload library update not recent changes. It is likely present since we moved to Webdav for file operations.

PVince81 · 2017-08-31T13:28:44Z

@SergioBertolinSG please retest

PVince81 · 2017-08-31T13:42:59Z

fix js tests

Related to jquery.fileupload upgrade, the event has moved

When uploading multiple files into a target folder, sometimes the progress bar does not disappear.

PVince81 · 2017-08-31T13:44:48Z

tests fixed

SergioBertolinSG · 2017-09-01T07:43:11Z

The estimation of the upload bar is very general (few seconds, minutes, etc) has it changed in this PR?

SergioBertolinSG · 2017-09-01T08:15:17Z

I guess it didn't so it works fine.

SergioBertolinSG

Works fine.

PVince81 · 2017-09-01T10:20:25Z

@SergioBertolinSG the estimate was never good...

jvillafanez

Code looks good

PVince81 · 2017-09-01T12:43:18Z

stable10: #28882

lock · 2019-08-02T15:02:58Z

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

PVince81 added 3 - To Review backport-request labels Aug 15, 2017

PVince81 added this to the development milestone Aug 15, 2017

PVince81 self-assigned this Aug 15, 2017

PVince81 requested a review from VicDeo August 15, 2017 10:48

This was referenced Aug 15, 2017

UI bug. File already exists window shows folder as file info. #28582

Closed

Drag and drop into subfolder uploads to current folder #28689

Closed

PVince81 added the p2-high Escalation, on top of current planning, release blocker label Aug 25, 2017

PVince81 requested a review from SergioBertolinSG August 29, 2017 17:39

jvillafanez reviewed Aug 31, 2017

View reviewed changes

PVince81 force-pushed the fix-filelist-drop-target branch from 77a0a40 to 3e9b68a Compare August 31, 2017 08:36

PVince81 mentioned this pull request Aug 31, 2017

[stable10] Make sure buttons stay in place even if the messages are really long owncloud/notifications#117

Merged

PVince81 added 2 - Developing and removed backport-request 3 - To Review labels Aug 31, 2017

PVince81 force-pushed the fix-filelist-drop-target branch from 3e9b68a to bab8bc8 Compare August 31, 2017 13:25

PVince81 mentioned this pull request Aug 31, 2017

Refresh file list row after upload into subfolder #28873

Closed

Vincent Petry added 2 commits August 31, 2017 15:44

Fix getting drop target when dragging from file manager

40f5aaf

Related to jquery.fileupload upgrade, the event has moved

Always pass requesttoken on uploads

8e30bb8

Progress bar must disappear at the of upload

8a69278

When uploading multiple files into a target folder, sometimes the progress bar does not disappear.

PVince81 force-pushed the fix-filelist-drop-target branch from bab8bc8 to 8a69278 Compare August 31, 2017 13:44

PVince81 mentioned this pull request Aug 31, 2017

Better timeout detection in web UI uploads + chunked uploads #28831

Merged

13 tasks

SergioBertolinSG added 3 - To Review and removed 2 - Developing labels Sep 1, 2017

SergioBertolinSG approved these changes Sep 1, 2017

View reviewed changes

PVince81 added 4 - To release backport-request and removed 3 - To Review labels Sep 1, 2017

PVince81 mentioned this pull request Sep 1, 2017

unreachable clamav in files_antivirus results in visual problems for the user #28870

Closed

jvillafanez approved these changes Sep 1, 2017

View reviewed changes

PVince81 mentioned this pull request Sep 1, 2017

[stable10] Fix getting drop target when dragging from file manager #28882

Merged

PVince81 removed the backport-request label Sep 1, 2017

PVince81 merged commit eb2ba34 into master Sep 1, 2017

PVince81 deleted the fix-filelist-drop-target branch September 1, 2017 13:22

SergioBertolinSG mentioned this pull request Sep 6, 2017

[stable10] Web UI goes back to old DAV endpoint #28924

Merged

ownclouders added the status/STALE label Dec 20, 2017

lock Bot locked as resolved and limited conversation to collaborators Aug 2, 2019

Uh oh!

Conversation

PVince81 commented Aug 15, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

Checklist:

Uh oh!

jvillafanez Aug 31, 2017

Choose a reason for hiding this comment

Uh oh!

PVince81 Aug 31, 2017

Choose a reason for hiding this comment

Uh oh!

PVince81 Aug 31, 2017

Choose a reason for hiding this comment

Uh oh!

SergioBertolinSG commented Aug 31, 2017 • edited by PVince81 Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

SergioBertolinSG commented Aug 31, 2017 • edited by PVince81 Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

PVince81 commented Aug 31, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jvillafanez commented Aug 31, 2017

Uh oh!

PVince81 commented Aug 31, 2017

Uh oh!

jvillafanez commented Aug 31, 2017

Uh oh!

SergioBertolinSG commented Aug 31, 2017

Uh oh!

PVince81 commented Aug 31, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

PVince81 commented Aug 31, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

PVince81 commented Aug 31, 2017

Uh oh!

PVince81 commented Aug 31, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

PVince81 commented Aug 31, 2017

Uh oh!

SergioBertolinSG commented Sep 1, 2017

Uh oh!

SergioBertolinSG commented Sep 1, 2017

Uh oh!

SergioBertolinSG left a comment

Choose a reason for hiding this comment

Uh oh!

PVince81 commented Sep 1, 2017

Uh oh!

jvillafanez left a comment

Choose a reason for hiding this comment

Uh oh!

PVince81 commented Sep 1, 2017

Uh oh!

lock Bot commented Aug 2, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

PVince81 commented Aug 15, 2017 •

edited

Loading

SergioBertolinSG commented Aug 31, 2017 •

edited by PVince81

Loading

SergioBertolinSG commented Aug 31, 2017 •

edited by PVince81

Loading

PVince81 commented Aug 31, 2017 •

edited

Loading

PVince81 commented Aug 31, 2017 •

edited

Loading

PVince81 commented Aug 31, 2017 •

edited

Loading

PVince81 commented Aug 31, 2017 •

edited

Loading