Skip to content

[stable10] Revert "Highlight files after setFiles"#29019

Merged
PVince81 merged 1 commit into
stable10from
stable10-filelist-scrollto-revert
Sep 15, 2017
Merged

[stable10] Revert "Highlight files after setFiles"#29019
PVince81 merged 1 commit into
stable10from
stable10-filelist-scrollto-revert

Conversation

@PVince81

Copy link
Copy Markdown
Contributor

Fixes #28106

See ticket for steps.

@PVince81

Copy link
Copy Markdown
Contributor Author

reverts #28665

@SergioBertolinSG

Copy link
Copy Markdown
Contributor

Works 👍

@PVince81

Copy link
Copy Markdown
Contributor Author

JS tests passed on CI. Waiting for Travis UI tests though.

@PVince81 PVince81 mentioned this pull request Sep 15, 2017
31 tasks
@phil-davis

phil-davis commented Sep 15, 2017

Copy link
Copy Markdown
Contributor

Note: Travis job https://travis-ci.org/owncloud/core/jobs/275851372 got:

     exception 'SensioLabs\Behat\PageObjectExtension\PageObject\Exception\UnexpectedPageException' with message 'Expected to be on "http://owncloud:8889/index.php/apps/files/" but found "http://owncloud:8889/index.php/login?redirect_url=%252Findex.php%252Fapps%252Ffiles%252F" instead' in /home/travis/build/owncloud/core/tests/ui/features/lib/FilesPage.php:166

is a "random" thing that happens sometimes (the SauceLabs video will show a sudden "CSRF Failed"), not related to this PR.

The job could be restarted, but it passed all other scenarios fine.

Update: all other Travis jobs have passed.
I restarted this job, just for fun, and since Jenkins has a while to go anyhow.
And it passed the 2nd time.

@PVince81
PVince81 merged commit 84c6927 into stable10 Sep 15, 2017
@PVince81
PVince81 deleted the stable10-filelist-scrollto-revert branch September 15, 2017 14:03
@lock

lock Bot commented Aug 2, 2019

Copy link
Copy Markdown

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock Bot locked as resolved and limited conversation to collaborators Aug 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants