Revert "Highlight files after setFiles"#29020
Merged
Merged
Conversation
This reverts commit 5350777.
Contributor
Author
|
@SergioBertolinSG also review/test this one (forward port to master) ? no rush |
Contributor
|
Doesn't work on current master. 👎 |
Contributor
|
It is like the highlight gets lost. |
Contributor
|
Ah nevermind, it is the same behaviour in stable10, the file is highlighted, but if you move the cursor on the rows and refresh the page, the highlight is lost. Not sure if we want to fix this. |
Contributor
Author
|
how do you move the cursor on the row ? if you mean when you open the sidebar by having the row selected, it doesn't affect the URL. The URL only points to the folder |
Contributor
|
Yeah, the url is right but after refreshing or moving it doesn't highlight the correct row:
|
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts PR #28665
Fixes #28106
See explanation here #28106 (comment)
stable10: #29019