Register type mappings on createSchema invocation too

[VicDeo]

Description

Register type mappings for MigrationService too

Related Issue

Fixes #29262

Motivation and Context

Smooth Upgrade process

How Has This Been Tested?

Manually. See exact steps in #29262

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

• My code follows the code style of this project.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I have read the CONTRIBUTING document.
• I have added tests to cover my changes.
• All new and existing tests passed.

[VicDeo]

One source was indented with spaces, so https://github.com/owncloud/core/pull/29263/files?w=1 is better to see what's changed

[codecov]

Codecov Report

Merging #29263 into master will increase coverage by 0.01%.
The diff coverage is 31.03%.

@@             Coverage Diff              @@
##             master   #29263      +/-   ##
============================================
+ Coverage     59.43%   59.44%   +0.01%     
- Complexity    17154    17158       +4     
============================================
  Files          1027     1027              
  Lines         57193    57203      +10     
============================================
+ Hits          33991    34004      +13     
+ Misses        23202    23199       -3

Impacted Files	Coverage Δ	Complexity Δ
lib/private/DB/OracleMigrator.php	0% <ø> (ø)	11 <0> (ø)	⬇️
lib/private/DB/MDB2SchemaManager.php	80.7% <0%> (ø)	17 <0> (ø)	⬇️
lib/private/DB/MySQLMigrator.php	0% <0%> (ø)	7 <4> (+2)	⬆️
lib/private/DB/SQLiteMigrator.php	100% <100%> (ø)	7 <2> (+2)	⬆️
lib/private/DB/Connection.php	65.89% <0%> (+3.1%)	45% <0%> (ø)	⬇️
lib/private/DB/Migrator.php	53.01% <0%> (+4.81%)	30% <0%> (ø)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d9f22f1...14b1384. Read the comment docs.

[VicDeo]

hmmm. should I revert tabs to spaces to satisfy that beasty mech ego?
registerAdditionalMappings and createSchema are covered in both classes, so the diff has coverage that is close to 100% in my Universe

[PVince81]

Add test to assert that the MySQL migrator did register additional type mappings ?

[VicDeo]

@PVince81 try to comment https://github.com/owncloud/core/pull/29263/files#diff-f31830e77645a4634cf4f0258e1a3272R35
and execute MySqlMigrationTest::testCreateSchemaWithNonOcTables

[PVince81]

@VicDeo explain that to codecov 😦

[VicDeo]

@PVince81 I have a strong impression that it counts coverage using sqlite only

[PVince81]

@DeepDiver1975 ignore codecov here then ?

[VicDeo]

The truth is that

• these two lines are now covered by tests:
  https://github.com/owncloud/core/pull/29263/files#diff-58177c1fd3826cc2a9f1f8e5b4736d7dR91
  https://github.com/owncloud/core/pull/29263/files#diff-1f3942e6e76594e802a7eb628c067f76R33

• changes in lib/private/DB/MySQLMigrator.php (excluding whitespaces) are 100% covered by tests/lib/DB/MySqlMigrationTest.php

• changes in lib/private/DB/SQLiteMigrator.php are 100% covered by tests/lib/DB/SqliteMigrationTest.php

[PVince81]

@VicDeo please backport to stable10

[VicDeo]

Without whitespaces 2/49 = 0.04081632653061224, so the coverage is 96%
With whitespaces it is 20/69 = 0.2898550724637681 and the coverage is 71%

[VicDeo]

Stable10: #29268

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.