Skip to content

[Stable10] Register type mappings on createSchema invocation too#29268

Merged
DeepDiver1975 merged 2 commits into
stable10from
stable10-fix-29262
Oct 19, 2017
Merged

[Stable10] Register type mappings on createSchema invocation too#29268
DeepDiver1975 merged 2 commits into
stable10from
stable10-fix-29262

Conversation

@VicDeo

@VicDeo VicDeo commented Oct 17, 2017

Copy link
Copy Markdown
Contributor

Description

Backport of #29263

Related Issue

Fixes #29262

See #29263 for details

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@PVince81 PVince81 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@PVince81

Copy link
Copy Markdown
Contributor

2 - Developing, do you intend to do changes that weren't on master ?

@VicDeo

VicDeo commented Oct 17, 2017

Copy link
Copy Markdown
Contributor Author

@PVince81 nothing changed, I just have no time to test it right now.

@VicDeo

VicDeo commented Oct 17, 2017

Copy link
Copy Markdown
Contributor Author

@PVince81 tested, works, but CI is stalled.

@codecov

codecov Bot commented Oct 17, 2017

Copy link
Copy Markdown

Codecov Report

❗ No coverage uploaded for pull request base (stable10@b8ce510). Click here to learn what that means.
The diff coverage is 31.03%.

Impacted file tree graph

@@             Coverage Diff             @@
##             stable10   #29268   +/-   ##
===========================================
  Coverage            ?   58.48%           
  Complexity          ?    17676           
===========================================
  Files               ?     1058           
  Lines               ?    59243           
  Branches            ?        0           
===========================================
  Hits                ?    34649           
  Misses              ?    24594           
  Partials            ?        0
Impacted Files Coverage Δ Complexity Δ
lib/private/DB/OracleMigrator.php 0% <ø> (ø) 10 <0> (?)
lib/private/DB/MySQLMigrator.php 0% <0%> (ø) 7 <4> (?)
lib/private/DB/MDB2SchemaManager.php 80.7% <0%> (ø) 17 <0> (?)
lib/private/DB/SQLiteMigrator.php 100% <100%> (ø) 7 <2> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b8ce510...956a1a7. Read the comment docs.

@VicDeo VicDeo force-pushed the stable10-fix-29262 branch from 9e20829 to d70a399 Compare October 18, 2017 09:34
@VicDeo

VicDeo commented Oct 18, 2017

Copy link
Copy Markdown
Contributor Author

rebased for CI

@VicDeo

VicDeo commented Oct 18, 2017

Copy link
Copy Markdown
Contributor Author

no way: '[ERROR] Waited 600 seconds, no response'

@VicDeo VicDeo force-pushed the stable10-fix-29262 branch from d70a399 to 956a1a7 Compare October 18, 2017 14:06
@DeepDiver1975 DeepDiver1975 merged commit ef290c2 into stable10 Oct 19, 2017
@DeepDiver1975 DeepDiver1975 deleted the stable10-fix-29262 branch October 19, 2017 17:42
@lock

lock Bot commented Aug 2, 2019

Copy link
Copy Markdown

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock Bot locked as resolved and limited conversation to collaborators Aug 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants