using LDAP users in UI tests - #30304
Conversation
phil-davis
left a comment
phil-davis
left a comment
There was a problem hiding this comment.
Looks like a good/flexible thing.
Having an "LDAP" tag on some scenarios gives the implication (not true) that the scenario might be just for LDAP. I am not sure how to get around that - people just need to understand what tags are used for, and that there is an implied "empty tag" that is "run all scenarios"
Codecov Report
@@ Coverage Diff @@
## master #30304 +/- ##
===========================================
+ Coverage 60.64% 60.84% +0.2%
Complexity 18549 18549
===========================================
Files 1092 1092
Lines 61278 61280 +2
===========================================
+ Hits 37160 37287 +127
+ Misses 24118 23993 -125
Continue to review full report at Codecov.
|
72a8704 to
8b172c5
Compare
|
@ownclouders rebase |
|
Hey! I'm GitMate.io! This pull request is being rebased automatically. Please DO NOT push while rebase is in progress or your changes would be lost permanently |
|
Automated rebase with GitMate.io was successful! 🎉 |
8b172c5 to
6cde03c
Compare
888b4a3 to
5d78b41
Compare
b4b1473 to
ad06869
Compare
individual-it
changed the title
|
cleaned stuff up, please review |
phil-davis
left a comment
phil-davis
left a comment
There was a problem hiding this comment.
It will work as it is, but there are a few comments about the logic to handle the occ method.
| //guess yourself | ||
| $method = "ldap"; | ||
| } else { | ||
| $method = "api"; |
There was a problem hiding this comment.
If $method is passed in here as occ (for example) then this code will go down this "else" and set (override) $method to be api
I don't see how method occ can be used?
| } | ||
| break; | ||
| case "ldap": | ||
| echo "creating LDAP users is not implemented, so assume they exists\n"; |
There was a problem hiding this comment.
s/they exists/they exist
| //guess yourself | ||
| $method = "ldap"; | ||
| } else { | ||
| $method = "api"; |
There was a problem hiding this comment.
Same here - how to use method occ ?
| } | ||
| break; | ||
| case "ldap": | ||
| echo "creating LDAP groups is not implemented, so assume they exists\n"; |
There was a problem hiding this comment.
s/they exists/they exist
| //guess yourself | ||
| $method = "ldap"; | ||
| } else { | ||
| $method = "api"; |
There was a problem hiding this comment.
Same here - how to use method occ ?
ad06869 to
9e6ee12
Compare
|
@phil-davis fixed the mentioned issues |
|
backport in #30349 |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
3 participants
Description
pseudo user creation in LDAP
Motivation and Context
we would like to run tests against a LDAP backend but not going throw the problems of creating the users/groups in PHP. So when running LDAP tests (TEST_LDAP env. variable set to "true") we assume the users/groups already exist in the LDAP server
So this would be a way to run at least some acceptance tests on LDAP with very minimal changes. See changes on the LDAP side owncloud/user_ldap#173
How Has This Been Tested?
run tests in drone owncloud/user_ldap#173
Types of changes
Checklist: