run core acceptance tests on LDAP using drone by individual-it · Pull Request #173 · owncloud/user_ldap

individual-it · 2018-01-29T08:35:35Z

run core UI tests that are marked with @TestAlsoOnExternalUserBackend
users/groups will not be created on the fly but pulled in from an ldif file

codecov-io · 2018-01-29T08:46:37Z

Codecov Report

Merging #173 into master will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #173   +/-   ##
=========================================
  Coverage     26.29%   26.29%           
  Complexity     1318     1318           
=========================================
  Files            47       47           
  Lines          4487     4487           
=========================================
  Hits           1180     1180           
  Misses         3307     3307

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 713c48e...bc78a2a. Read the comment docs.

phil-davis

Looks like "a good thing"
Once the code is merged in master then I guess some of the "arturneumann" specific stuff can be changed to directly use the core code from master.

phil-davis · 2018-01-29T13:20:01Z

+      - cd /var/www/owncloud/apps/user_ldap
+      - make
+      - cd /var/www/owncloud/
+      - php occ a:l


Everyone seems to use shorthand for app:list app:enable ...

Regarding install - can you switch to using https://github.com/owncloud-ci/core

It allows for using a branch/tarball

phil-davis · 2018-01-29T13:22:33Z

 		$availableConfigs = $helper->getServerConfigurationPrefixes();
 		$configID = $input->getArgument('configID');
 		if(!in_array($configID, $availableConfigs)) {
+			var_dump($availableConfigs);


bonus debugging code

will have to be cleaned up before merging, would like to keep it while [WIP]

Debug line is now gone 👍

patrickjahns · 2018-01-31T13:12:22Z

+
+pipeline:
+  ldap:
+    image: dinkel/openldap


What made you use this ldap container - compared to osixia/openldap which we use in other infrastructure projects?

this script https://github.com/owncloud/administration/blob/master/ldap-testing/start.sh

Ah didn't find these before :'(

individual-it · 2018-02-05T08:12:20Z

@phil-davis @patrickjahns I feel this is ready to go. Any more comments/change requests or should we merge?

phil-davis

LGTM

patrickjahns · 2018-02-05T11:24:35Z

What's the status on the core side? If we have the required changes in master/stable10 please update the install_server step to use nightly tarballs again.

It looks fine for the first iteration - I'd like to also port the tests suites from .travis to drone at some point

individual-it · 2018-02-05T13:14:29Z

thank you for reminding to change the source.
core should be fine, but looks like something changed in master in between.

cannot sync users

An unhandled exception has been thrown:
TypeError: Argument 1 passed to OC\User\SyncService::syncAccount() must be an instance of OC\User\Account, null given, called in /var/www/owncloud/lib/private/User/SyncService.php on line 121 and defined in /var/www/owncloud/lib/private/User/SyncService.php:279
Stack trace:
#0 /var/www/owncloud/lib/private/User/SyncService.php(121): OC\User\SyncService->syncAccount(NULL, Object(OCA\User_LDAP\User_Proxy))
#1 /var/www/owncloud/core/Command/User/SyncBackend.php(148): OC\User\SyncService->run(Object(OCA\User_LDAP\User_Proxy), Object(Closure))
#2 /var/www/owncloud/lib/composer/symfony/console/Command/Command.php(252): OC\Core\Command\User\SyncBackend->execute(Object(Symfony\Component\Console\Input\ArgvInput), Object(Symfony\Component\Console\Output\ConsoleOutput))
#3 /var/www/owncloud/lib/composer/symfony/console/Application.php(938): Symfony\Component\Console\Command\Command->run(Object(Symfony\Component\Console\Input\ArgvInput), Object(Symfony\Component\Console\Output\ConsoleOutput))
#4 /var/www/owncloud/lib/composer/symfony/console/Application.php(240): Symfony\Component\Console\Application->doRunCommand(Object(OC\Core\Command\User\SyncBackend), Object(Symfony\Component\Console\Input\ArgvInput), Object(Symfony\Component\Console\Output\ConsoleOutput))
#5 /var/www/owncloud/lib/composer/symfony/console/Application.php(148): Symfony\Component\Console\Application->doRun(Object(Symfony\Component\Console\Input\ArgvInput), Object(Symfony\Component\Console\Output\ConsoleOutput))
#6 /var/www/owncloud/lib/private/Console/Application.php(161): Symfony\Component\Console\Application->run(Object(Symfony\Component\Console\Input\ArgvInput), Object(Symfony\Component\Console\Output\ConsoleOutput))
#7 /var/www/owncloud/console.php(106): OC\Console\Application->run()
#8 /var/www/owncloud/occ(11): require_once('/var/www/ownclo...')
    1 [->--------------------------] 0/6 [>---------------------------]   0%
#9 {main}

I will look into it

individual-it · 2018-02-05T13:38:07Z

works fine on stable10 but on master there is an issue see owncloud/core#30369

tomneedham · 2018-02-07T12:58:14Z

Restart CI - master fix PR is in.

patrickjahns · 2018-02-07T13:02:14Z

Restarted builds - when green we can merge

individual-it · 2018-02-07T13:23:23Z

CI will not become green because it using the daily builds

individual-it · 2018-02-07T13:31:50Z

owncloud/core#30367 fixes the issue, CI should be green tomorrow

individual-it force-pushed the acceptance-tests branch from b15c593 to e13dab7 Compare January 29, 2018 09:21

individual-it mentioned this pull request Jan 29, 2018

using LDAP users in UI tests owncloud/core#30304

Merged

9 tasks

individual-it self-assigned this Jan 29, 2018

individual-it requested review from patrickjahns and phil-davis January 29, 2018 11:52

individual-it changed the title ~~run core acceptance tests on LDAP using drone~~ [WIP] run core acceptance tests on LDAP using drone Jan 29, 2018

phil-davis reviewed Jan 29, 2018

View reviewed changes

patrickjahns reviewed Jan 31, 2018

View reviewed changes

individual-it force-pushed the acceptance-tests branch 6 times, most recently from f730c5a to be8e56f Compare February 2, 2018 10:43

individual-it changed the title ~~[WIP] run core acceptance tests on LDAP using drone~~ run core acceptance tests on LDAP using drone Feb 5, 2018

individual-it added the 3 - To Review label Feb 5, 2018

phil-davis approved these changes Feb 5, 2018

View reviewed changes

individual-it force-pushed the acceptance-tests branch from be8e56f to 62b8038 Compare February 5, 2018 12:41

tomneedham added this to the development milestone Feb 7, 2018

individual-it force-pushed the acceptance-tests branch from 62b8038 to 04a4083 Compare February 8, 2018 10:20

run core UI tests on LDAP using drone

bc78a2a

individual-it force-pushed the acceptance-tests branch from 04a4083 to bc78a2a Compare February 8, 2018 10:56

individual-it merged commit 29b2e4e into master Feb 9, 2018

individual-it deleted the acceptance-tests branch February 9, 2018 09:53

Uh oh!

Conversation

individual-it commented Jan 29, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov-io commented Jan 29, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

phil-davis left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

individual-it commented Feb 5, 2018

Uh oh!

phil-davis left a comment

Choose a reason for hiding this comment

Uh oh!

patrickjahns commented Feb 5, 2018

Uh oh!

individual-it commented Feb 5, 2018

Uh oh!

individual-it commented Feb 5, 2018

Uh oh!

tomneedham commented Feb 7, 2018

Uh oh!

patrickjahns commented Feb 7, 2018

Uh oh!

individual-it commented Feb 7, 2018

Uh oh!

individual-it commented Feb 7, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

individual-it commented Jan 29, 2018 •

edited

Loading

codecov-io commented Jan 29, 2018 •

edited

Loading