Skip to content

Add confirm password after new password - #30981

Merged
PVince81 merged 1 commit into
masterfrom
retype-password-reset
Feb 14, 2019
Merged

Add confirm password after new password#30981
PVince81 merged 1 commit into
masterfrom
retype-password-reset

Conversation

@sharidas

@sharidas sharidas commented Apr 2, 2018

Copy link
Copy Markdown
Contributor

The confirm password would help to validate
if the password entered is same as new
password entered.

Signed-off-by: Sujith H sharidasan@owncloud.com

Description

The confirm password text box would help users to validate the new password. If there is any mismatch between 2 passwords then no reset action should take place.

Related Issue

#29901

Motivation and Context

The confirm password text box would help users to validate the new password. If there is any mismatch between 2 passwords then no reset action should take place.

How Has This Been Tested?

Screenshots (if appropriate):

confirmpassword1

confirmpassword2

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@sharidas sharidas added this to the development milestone Apr 2, 2018
@sharidas sharidas self-assigned this Apr 2, 2018
@codecov

codecov Bot commented Apr 2, 2018

Copy link
Copy Markdown

Codecov Report

Merging #30981 into master will decrease coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #30981      +/-   ##
============================================
- Coverage     64.84%   64.84%   -0.01%     
  Complexity    18324    18324              
============================================
  Files          1198     1198              
  Lines         69580    69579       -1     
  Branches       1283     1283              
============================================
- Hits          45120    45118       -2     
- Misses        24086    24087       +1     
  Partials        374      374
Flag Coverage Δ Complexity Δ
#javascript 53.1% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 66.2% <0%> (-0.01%) 18324 <0> (ø)
Impacted Files Coverage Δ Complexity Δ
core/templates/lostpassword/resetpassword.php 0% <0%> (ø) 0 <0> (ø) ⬇️
apps/files_trashbin/lib/Expiration.php 96.55% <0%> (-1.73%) 29% <0%> (ø)
...eratedfilesharing/lib/Controller/OcmController.php 66.06% <0%> (-0.21%) 30% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1665fef...c5fa36a. Read the comment docs.

@PVince81 PVince81 modified the milestones: development, planned Apr 3, 2018
@PVince81 PVince81 modified the milestones: development, triage Apr 25, 2018
@PVince81 PVince81 modified the milestones: triage, maybe some day May 22, 2018
@PVince81

Copy link
Copy Markdown
Contributor

@pmaier1 see above, looks like this would be useful

@PVince81

Copy link
Copy Markdown
Contributor

for consistency, might need to add a "confirm second password" to the personal page

@PVince81

PVince81 commented Feb 8, 2019

Copy link
Copy Markdown
Contributor

@sharidas please rebase.

if this is finished we could move forward as it's a nice addition

@phil-davis

Copy link
Copy Markdown
Contributor

This will need some webUILogin acceptance test changes - the UI workflow changes and the acceptance test will need to input the new password twice now.

@sharidas

sharidas commented Feb 11, 2019

Copy link
Copy Markdown
Contributor Author
  • Need to adjust the acceptance test.

@sharidas
sharidas force-pushed the retype-password-reset branch 3 times, most recently from 13c6cd4 to f0d9cae Compare February 11, 2019 10:16
@sharidas
sharidas force-pushed the retype-password-reset branch 2 times, most recently from 507d410 to fdada49 Compare February 14, 2019 06:28
The confirm password would help to validate
if the password entered is same as new
password entered.

Signed-off-by: Sujith H <sharidasan@owncloud.com>

@PVince81 PVince81 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@PVince81

Copy link
Copy Markdown
Contributor

we can ignore codecov as this is covered by acceptance tests

@PVince81
PVince81 merged commit 406498a into master Feb 14, 2019
@delete-merged-branch
delete-merged-branch Bot deleted the retype-password-reset branch February 14, 2019 16:22
@PVince81

Copy link
Copy Markdown
Contributor

@sharidas please backport

@phil-davis

Copy link
Copy Markdown
Contributor

@sharidas I will make a backport of this PR and PR #34490 together in a moment.

@phil-davis

Copy link
Copy Markdown
Contributor

Backport stable10 #34492

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants