Skip to content

[stable10] Add confirm password after new password - #34492

Merged
phil-davis merged 5 commits into
stable10from
stable10-retype-password-reset
Feb 15, 2019
Merged

[stable10] Add confirm password after new password#34492
phil-davis merged 5 commits into
stable10from
stable10-retype-password-reset

Conversation

@phil-davis

@phil-davis phil-davis commented Feb 15, 2019

Copy link
Copy Markdown
Contributor

Backport PRs #30981 and #34490
And adjust confirm password steps for webUIManageUsersGroups/addUsers.feature which only exists in core stable10
Backport owncloud-archive/user_management#146 changes for user_management issue owncloud-archive/user_management#147

sharidas and others added 3 commits February 15, 2019 09:27
The confirm password would help to validate
if the password entered is same as new
password entered.

Signed-off-by: Sujith H <sharidasan@owncloud.com>
@codecov

codecov Bot commented Feb 15, 2019

Copy link
Copy Markdown

Codecov Report

Merging #34492 into stable10 will decrease coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@              Coverage Diff               @@
##             stable10   #34492      +/-   ##
==============================================
- Coverage        63.6%    63.6%   -0.01%     
  Complexity      19091    19091              
==============================================
  Files            1264     1264              
  Lines           75303    75302       -1     
  Branches         1291     1291              
==============================================
- Hits            47897    47894       -3     
- Misses          27026    27028       +2     
  Partials          380      380
Flag Coverage Δ Complexity Δ
#javascript 53.32% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 64.7% <0%> (-0.01%) 19091 <0> (ø)
Impacted Files Coverage Δ Complexity Δ
core/templates/lostpassword/resetpassword.php 0% <0%> (ø) 0 <0> (ø) ⬇️
apps/encryption/lib/Session.php 98.03% <0%> (-1.97%) 22% <0%> (ø)
apps/files_trashbin/lib/Expiration.php 96.55% <0%> (-1.73%) 29% <0%> (ø)
...eratedfilesharing/lib/Controller/OcmController.php 66.06% <0%> (-0.21%) 30% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fc04927...814b7a1. Read the comment docs.

@codecov

codecov Bot commented Feb 15, 2019

Copy link
Copy Markdown

Codecov Report

Merging #34492 into stable10 will decrease coverage by 0.01%.
The diff coverage is 22.22%.

Impacted file tree graph

@@              Coverage Diff               @@
##             stable10   #34492      +/-   ##
==============================================
- Coverage        63.6%   63.59%   -0.02%     
  Complexity      19091    19091              
==============================================
  Files            1264     1264              
  Lines           75303    75316      +13     
  Branches         1291     1292       +1     
==============================================
  Hits            47897    47897              
- Misses          27026    27039      +13     
  Partials          380      380
Flag Coverage Δ Complexity Δ
#javascript 53.27% <26.66%> (-0.06%) 0 <0> (ø)
#phpunit 64.7% <0%> (-0.01%) 19091 <0> (ø)
Impacted Files Coverage Δ Complexity Δ
core/templates/lostpassword/resetpassword.php 0% <0%> (ø) 0 <0> (ø) ⬇️
settings/templates/setpassword.php 0% <0%> (ø) 0 <0> (ø) ⬇️
settings/js/setpassword.js 66.66% <26.66%> (-16.2%) 0 <0> (ø)
apps/encryption/lib/Session.php 98.03% <0%> (-1.97%) 22% <0%> (ø)
apps/files_trashbin/lib/Expiration.php 96.55% <0%> (-1.73%) 29% <0%> (ø)
...eratedfilesharing/lib/Controller/OcmController.php 66.06% <0%> (-0.21%) 30% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fc04927...51db421. Read the comment docs.

@sharidas sharidas left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@phil-davis

phil-davis commented Feb 15, 2019

Copy link
Copy Markdown
Contributor Author

ToDo;

@phil-davis

Copy link
Copy Markdown
Contributor Author

Note to self: this should be a consistent package of changes now. If CI passes. merge quickly ;)

@phil-davis
phil-davis force-pushed the stable10-retype-password-reset branch from e47716e to c64ae49 Compare February 15, 2019 07:24
@phil-davis
phil-davis force-pushed the stable10-retype-password-reset branch from c64ae49 to 51db421 Compare February 15, 2019 08:17
@phil-davis
phil-davis merged commit 1fcdad1 into stable10 Feb 15, 2019
@delete-merged-branch
delete-merged-branch Bot deleted the stable10-retype-password-reset branch February 15, 2019 09:03
@phil-davis phil-davis mentioned this pull request Feb 18, 2019
11 tasks
@PVince81 PVince81 added this to the QA milestone Apr 12, 2019
@lock lock Bot locked as resolved and limited conversation to collaborators Apr 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants