Style of acceptance test string concatenation#32336
Conversation
Codecov Report
@@ Coverage Diff @@
## master #32336 +/- ##
=========================================
Coverage 64.01% 64.01%
Complexity 18564 18564
=========================================
Files 1171 1171
Lines 69851 69851
Branches 1267 1267
=========================================
Hits 44714 44714
Misses 24767 24767
Partials 370 370
Continue to review full report at Codecov.
|
7d3caaf to
4bededb
Compare
5475cfc to
afcda1c
Compare
|
@individual-it @DeepDiver1975 please comment - what is the project "standard" for forming strings in PHP? |
|
Benefits in Performance and memory consumption are to be ignored when comparing string concat vs string Interpolation. |
|
@DeepDiver1975 do the style of changes I made here match the style you would like to have? |
|
@DeepDiver1975 @individual-it comments or approval please. |
individual-it
left a comment
There was a problem hiding this comment.
I like concatenation more, but lets not get blocked by that and just define this as standard and get on with work
|
Backport |
Description
Adjust the style of string concatenation in places that I found.
Motivation and Context
Review comment #29773 (comment)
How Has This Been Tested?
CI
Types of changes
Checklist:
Open tasks: