Skip to content

[stable10] Style of acceptance test string concatenation#32393

Merged
phil-davis merged 4 commits into
stable10from
stable10-acceptance-test-code-style-20180814
Aug 21, 2018
Merged

[stable10] Style of acceptance test string concatenation#32393
phil-davis merged 4 commits into
stable10from
stable10-acceptance-test-code-style-20180814

Conversation

@phil-davis

Copy link
Copy Markdown
Contributor

Backport #32336

@phil-davis phil-davis merged commit 538522c into stable10 Aug 21, 2018
@phil-davis phil-davis deleted the stable10-acceptance-test-code-style-20180814 branch August 21, 2018 10:27
@codecov

codecov Bot commented Aug 21, 2018

Copy link
Copy Markdown

Codecov Report

Merging #32393 into stable10 will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff               @@
##             stable10   #32393      +/-   ##
==============================================
+ Coverage        62.8%    62.8%   +<.01%     
  Complexity      18759    18759              
==============================================
  Files            1220     1220              
  Lines           73476    73476              
  Branches         1279     1279              
==============================================
+ Hits            46145    46148       +3     
+ Misses          26951    26948       -3     
  Partials          380      380
Flag Coverage Δ Complexity Δ
#javascript 53.11% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 63.86% <ø> (ø) 18759 <ø> (ø) ⬇️
Impacted Files Coverage Δ Complexity Δ
lib/private/Files/Storage/Wrapper/Encryption.php 68.05% <0%> (+0.24%) 156% <0%> (ø) ⬇️
apps/encryption/lib/Session.php 100% <0%> (+1.96%) 22% <0%> (ø) ⬇️
apps/encryption/templates/settings-admin.php 94.11% <0%> (+5.88%) 0% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 13efb13...aafe577. Read the comment docs.

@PVince81 PVince81 modified the milestones: development, QA Sep 5, 2018
@lock lock Bot locked as resolved and limited conversation to collaborators Sep 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants