Skip to content

[WIP] Update guzzle to 6.3#32526

Closed
phil-davis wants to merge 6 commits into
masterfrom
update-guzzle-4
Closed

[WIP] Update guzzle to 6.3#32526
phil-davis wants to merge 6 commits into
masterfrom
update-guzzle-4

Conversation

@phil-davis

@phil-davis phil-davis commented Aug 31, 2018

Copy link
Copy Markdown
Contributor

Interim code with some PRs squashed.

@phil-davis phil-davis self-assigned this Aug 31, 2018
@phil-davis phil-davis mentioned this pull request Aug 31, 2018
Closed
@phil-davis

phil-davis commented Aug 31, 2018

Copy link
Copy Markdown
Contributor Author

Now we are down to just some PHPunit fails on sqLite:
https://drone.owncloud.com/owncloud/core/9958/166

...............................                               9303 / 9303 (100%)

Time: 13.65 minutes, Memory: 2552.00MB

There were 7 errors:

1) Test\Http\Client\ClientTest::testGet
Error: Call to undefined method Mock_Client_66d8a89c::getConfig()

/drone/src/lib/private/Http/Client/Client.php:65
/drone/src/lib/private/Http/Client/Client.php:136
/drone/src/tests/lib/Http/Client/ClientTest.php:93

2) Test\Http\Client\ClientTest::testPost
Error: Call to undefined method Mock_Client_66d8a89c::getConfig()

/drone/src/lib/private/Http/Client/Client.php:65
/drone/src/lib/private/Http/Client/Client.php:202
/drone/src/tests/lib/Http/Client/ClientTest.php:99

3) Test\Http\Client\ClientTest::testPut
Error: Call to undefined method Mock_Client_66d8a89c::getConfig()

/drone/src/lib/private/Http/Client/Client.php:65
/drone/src/lib/private/Http/Client/Client.php:241
/drone/src/tests/lib/Http/Client/ClientTest.php:105

4) Test\Http\Client\ClientTest::testDelete
Error: Call to undefined method Mock_Client_66d8a89c::getConfig()

/drone/src/lib/private/Http/Client/Client.php:65
/drone/src/lib/private/Http/Client/Client.php:276
/drone/src/tests/lib/Http/Client/ClientTest.php:111

5) Test\Http\Client\ClientTest::testOptions
Error: Call to undefined method Mock_Client_66d8a89c::getConfig()

/drone/src/lib/private/Http/Client/Client.php:65
/drone/src/lib/private/Http/Client/Client.php:311
/drone/src/tests/lib/Http/Client/ClientTest.php:117

6) OCA\Files_Sharing\Tests\WatcherTest::testFolderSizePropagationToOwnerStorage
TypeError: Argument 1 passed to Aws\Handler\GuzzleV5\GuzzleHandler::Aws\Handler\GuzzleV5\{closure}() must be an instance of Exception, instance of TypeError given, called in /drone/src/apps/files_primary_s3/vendor/guzzlehttp/promises/src/RejectedPromise.php on line 40

/drone/src/apps/files_primary_s3/vendor/aws/aws-sdk-php/src/Handler/GuzzleV5/GuzzleHandler.php:82
/drone/src/apps/files_primary_s3/vendor/guzzlehttp/promises/src/RejectedPromise.php:40
/drone/src/apps/files_primary_s3/vendor/guzzlehttp/promises/src/TaskQueue.php:47
/drone/src/apps/files_primary_s3/vendor/guzzlehttp/promises/src/Promise.php:246
/drone/src/apps/files_primary_s3/vendor/guzzlehttp/promises/src/Promise.php:223
/drone/src/apps/files_primary_s3/vendor/guzzlehttp/promises/src/Promise.php:267
/drone/src/apps/files_primary_s3/vendor/guzzlehttp/promises/src/Promise.php:225
/drone/src/apps/files_primary_s3/vendor/guzzlehttp/promises/src/Promise.php:62
/drone/src/apps/files_primary_s3/vendor/aws/aws-sdk-php/src/AwsClientTrait.php:58
/drone/src/apps/files_primary_s3/lib/streamwrapper.php:660
/drone/src/apps/files_primary_s3/lib/streamwrapper.php:143
/drone/src/apps/files_primary_s3/lib/streamwrapper.php:875
/drone/src/apps/files_primary_s3/lib/streamwrapper.php:147
/drone/src/apps/files_primary_s3/lib/s3storage.php:151
/drone/src/lib/private/Files/ObjectStore/ObjectStoreStorage.php:271
/drone/src/lib/private/Files/ObjectStore/ObjectStoreStorage.php:300
/drone/src/lib/private/Files/Storage/Common.php:197
/drone/src/lib/private/Files/Storage/Wrapper/Wrapper.php:252
/drone/src/lib/private/Files/Storage/Wrapper/Availability.php:274
/drone/src/lib/private/Files/Storage/Wrapper/Checksum.php:191
/drone/src/lib/private/Files/Storage/Wrapper/Jail.php:251
/drone/src/apps/files_sharing/lib/SharedStorage.php:452
/drone/src/apps/files_sharing/tests/WatcherTest.php:113

7) OCA\Files_Sharing\Tests\WatcherTest::testSubFolderSizePropagationToOwnerStorage
TypeError: Argument 1 passed to Aws\Handler\GuzzleV5\GuzzleHandler::Aws\Handler\GuzzleV5\{closure}() must be an instance of Exception, instance of TypeError given, called in /drone/src/apps/files_primary_s3/vendor/guzzlehttp/promises/src/RejectedPromise.php on line 40

/drone/src/apps/files_primary_s3/vendor/aws/aws-sdk-php/src/Handler/GuzzleV5/GuzzleHandler.php:82
/drone/src/apps/files_primary_s3/vendor/guzzlehttp/promises/src/RejectedPromise.php:40
/drone/src/apps/files_primary_s3/vendor/guzzlehttp/promises/src/TaskQueue.php:47
/drone/src/apps/files_primary_s3/vendor/guzzlehttp/promises/src/Promise.php:246
/drone/src/apps/files_primary_s3/vendor/guzzlehttp/promises/src/Promise.php:223
/drone/src/apps/files_primary_s3/vendor/guzzlehttp/promises/src/Promise.php:267
/drone/src/apps/files_primary_s3/vendor/guzzlehttp/promises/src/Promise.php:225
/drone/src/apps/files_primary_s3/vendor/guzzlehttp/promises/src/Promise.php:62
/drone/src/apps/files_primary_s3/vendor/aws/aws-sdk-php/src/AwsClientTrait.php:58
/drone/src/apps/files_primary_s3/lib/streamwrapper.php:660
/drone/src/apps/files_primary_s3/lib/streamwrapper.php:143
/drone/src/apps/files_primary_s3/lib/streamwrapper.php:875
/drone/src/apps/files_primary_s3/lib/streamwrapper.php:147
/drone/src/apps/files_primary_s3/lib/s3storage.php:151
/drone/src/lib/private/Files/ObjectStore/ObjectStoreStorage.php:271
/drone/src/lib/private/Files/ObjectStore/ObjectStoreStorage.php:300
/drone/src/lib/private/Files/Storage/Common.php:197
/drone/src/lib/private/Files/Storage/Wrapper/Wrapper.php:252
/drone/src/lib/private/Files/Storage/Wrapper/Availability.php:274
/drone/src/lib/private/Files/Storage/Wrapper/Checksum.php:191
/drone/src/lib/private/Files/Storage/Wrapper/Jail.php:251
/drone/src/apps/files_sharing/lib/SharedStorage.php:452
/drone/src/apps/files_sharing/tests/WatcherTest.php:143

@phil-davis

phil-davis commented Aug 31, 2018

Copy link
Copy Markdown
Contributor Author

Next interim PR is #32532 - which rebases and resolves changes due to the introduction of HttpRequestHelper for acceptance tests.

@phil-davis phil-davis closed this Aug 31, 2018
@phil-davis phil-davis deleted the update-guzzle-4 branch August 31, 2018 13:49
@lock lock Bot locked as resolved and limited conversation to collaborators Aug 31, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

@phil-davis phil-davis

Labels

2 - Developing dependencies

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@phil-davis