[WIP] Update guzzle to 6.3#32532
Conversation
phil-davis
force-pushed
the
update-guzzle-5
branch
from
754faf3 to
271aee7
Compare
Codecov Report
@@ Coverage Diff @@
## master #32532 +/- ##
=============================================
- Coverage 64.1% 47.89% -16.21%
=============================================
Files 1176 109 -1067
Lines 70206 10445 -59761
Branches 1270 1270
=============================================
- Hits 45004 5003 -40001
+ Misses 24832 5072 -19760
Partials 370 370
Continue to review full report at Codecov.
|
| public function post($uri, array $options = []) { | ||
| $this->setDefaultOptions(); | ||
| if (isset($options['body']) && is_array($options['body'])) { | ||
| if (isset($options['body']) && \is_array($options['body'])) { |
There was a problem hiding this comment.
This should happen in an earlier commit.
| <IfModule pagespeed_module> | ||
| ModPagespeed Off | ||
| </IfModule> | ||
|
|
There was a problem hiding this comment.
Need to get rid of this accidental change.
| * | ||
| * @return SimpleXMLElement | ||
| */ | ||
| public function getResponseXml($response = null) { |
There was a problem hiding this comment.
ToDo: there are a few copies of these getResponseXml() functions in this PR. Sort out 1 place to put it.
| } | ||
|
|
||
| if ($headers !== null) { | ||
| if ($headers === null) { |
There was a problem hiding this comment.
ToDo: I don't think making this an empty array is needed. Should be able to pass null straight through OK.
| private function createGuzzleClientException($statusCode) { | ||
| $request = $this->createMock(\GuzzleHttp\Message\RequestInterface::class); | ||
| $response = $this->createMock(\GuzzleHttp\Message\ResponseInterface::class); | ||
| $request = $this->createMock(RequestInterface::class); |
There was a problem hiding this comment.
These changes should go in an earlier commit - they are not acceptance test stuff.
phil-davis
force-pushed
the
update-guzzle-5
branch
from
4ac1038 to
2695f05
Compare
phil-davis
force-pushed
the
update-guzzle-5
branch
from
2695f05 to
5bd4645
Compare
|
Next Guzzle V6 PR is #32537 |
1 participant
Rebased with latest master acceptance test code.