Skip to content

Conversation

@DeepDiver1975
Copy link
Member

@DeepDiver1975 DeepDiver1975 commented Nov 5, 2018

…t installed

Description

Side effect of #26608

In case owncloud is not yet installed we cannot call Share::isEnabled because this results in table not found exception

Related Issue

How Has This Been Tested?

  • try to install owncloud via the web ui
  • ensure config.php as well as for sqlite the database file is deleted

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • Backport (if applicable set "backport-request" label and remove when the backport was done)

Copy link
Contributor

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@PVince81 PVince81 added this to the development milestone Nov 5, 2018
@codecov
Copy link

codecov bot commented Nov 5, 2018

Codecov Report

Merging #33414 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #33414      +/-   ##
============================================
+ Coverage     64.06%   64.06%   +<.01%     
- Complexity    18277    18278       +1     
============================================
  Files          1190     1190              
  Lines         69044    69045       +1     
  Branches       1271     1271              
============================================
+ Hits          44234    44235       +1     
  Misses        24440    24440              
  Partials        370      370
Flag Coverage Δ Complexity Δ
#javascript 52.88% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 65.36% <100%> (ø) 18278 <0> (+1) ⬆️
Impacted Files Coverage Δ Complexity Δ
lib/private/legacy/template.php 58.94% <100%> (+0.21%) 42 <0> (+1) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 79afae1...ac4a21b. Read the comment docs.

@DeepDiver1975 DeepDiver1975 merged commit 781c677 into master Nov 5, 2018
@DeepDiver1975 DeepDiver1975 deleted the bugfix/33408 branch November 5, 2018 10:10
@lordelix
Copy link
Contributor

lordelix commented Nov 5, 2018

WOHOOO … :-)

@PVince81 PVince81 mentioned this pull request Nov 5, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Nov 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Seems like ownCloud tries to select from a database table before creating it

4 participants