Skip to content

Create new method for uploading file with headers in tests#33784

Merged
phil-davis merged 1 commit into
masterfrom
upload-file-method
Dec 7, 2018
Merged

Create new method for uploading file with headers in tests#33784
phil-davis merged 1 commit into
masterfrom
upload-file-method

Conversation

@dpakach

@dpakach dpakach commented Dec 6, 2018

Copy link
Copy Markdown
Contributor

Description

Add new method to upload file in webdav.php for uploading file with headers

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • Backport (if applicable set "backport-request" label and remove when the backport was done)

@phil-davis phil-davis left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess that you want to use this new method from other places?
Oh, I see you already put a link to firewall.

@dpakach

dpakach commented Dec 6, 2018

Copy link
Copy Markdown
Contributor Author

Stable10 backport in #33787

@phil-davis

Copy link
Copy Markdown
Contributor

@ownclouders rebase

@ownclouders

Copy link
Copy Markdown
Contributor

Hey! I'm GitMate.io! This pull request is being rebased automatically. Please DO NOT push while rebase is in progress or your changes would be lost permanently ⚠️

@ownclouders

Copy link
Copy Markdown
Contributor

Automated rebase with GitMate.io was successful! 🎉

@phil-davis

Copy link
Copy Markdown
Contributor

@dpakach conflicts to resolve
Note: I also fixed a php-cs-fixer code style error last night, so make sure to pull the latest branch from github first.

@dpakach dpakach force-pushed the upload-file-method branch from 58c4f4c to 406a214 Compare December 7, 2018 05:23
@codecov

codecov Bot commented Dec 7, 2018

Copy link
Copy Markdown

Codecov Report

Merging #33784 into master will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #33784      +/-   ##
============================================
+ Coverage     64.35%   64.35%   +<.01%     
  Complexity    18309    18309              
============================================
  Files          1195     1195              
  Lines         69255    69256       +1     
  Branches       1276     1276              
============================================
+ Hits          44566    44567       +1     
  Misses        24317    24317              
  Partials        372      372
Flag Coverage Δ Complexity Δ
#javascript 52.98% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 65.66% <ø> (ø) 18309 <ø> (ø) ⬇️
Impacted Files Coverage Δ Complexity Δ
...eratedfilesharing/lib/Controller/OcmController.php 66.26% <0%> (+0.2%) 30% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ec7fb94...406a214. Read the comment docs.

@codecov

codecov Bot commented Dec 7, 2018

Copy link
Copy Markdown

Codecov Report

Merging #33784 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #33784   +/-   ##
=========================================
  Coverage     64.35%   64.35%           
  Complexity    18309    18309           
=========================================
  Files          1195     1195           
  Lines         69255    69255           
  Branches       1276     1276           
=========================================
  Hits          44566    44566           
  Misses        24317    24317           
  Partials        372      372
Flag Coverage Δ Complexity Δ
#javascript 52.98% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 65.66% <ø> (ø) 18309 <ø> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ec7fb94...db9d125. Read the comment docs.

@phil-davis

Copy link
Copy Markdown
Contributor

@dpakach it still says there are conflicts

@dpakach

dpakach commented Dec 7, 2018

Copy link
Copy Markdown
Contributor Author

@dpakach it still says there are conflicts

Ok I didnt noticed your comment before I am working to fix this

@dpakach dpakach force-pushed the upload-file-method branch from 406a214 to db9d125 Compare December 7, 2018 05:35
@phil-davis phil-davis merged commit 4ab9e01 into master Dec 7, 2018
@delete-merged-branch delete-merged-branch Bot deleted the upload-file-method branch December 7, 2018 09:17
@lock lock Bot locked as resolved and limited conversation to collaborators Dec 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants