Fix conflict resolution of uploadFileWithHeaders#33815
Merged
Merged
Conversation
individual-it
approved these changes
Dec 7, 2018
Contributor
Author
|
Backport |
Codecov Report
@@ Coverage Diff @@
## master #33815 +/- ##
=========================================
Coverage 64.35% 64.35%
Complexity 18309 18309
=========================================
Files 1195 1195
Lines 69255 69255
Branches 1276 1276
=========================================
Hits 44566 44566
Misses 24317 24317
Partials 372 372
Continue to review full report at Codecov.
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #33815 +/- ##
=========================================
Coverage 64.35% 64.35%
Complexity 18309 18309
=========================================
Files 1195 1195
Lines 69255 69255
Branches 1276 1276
=========================================
Hits 44566 44566
Misses 24317 24317
Partials 372 372
Continue to review full report at Codecov.
|
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
$noOfChunkstouploadFileWithHeaders()pauseUpload()Motivation and Context
Conflict resolution in #33784 missed changes that happened at a similar time for upload timing issues - adding
pauseUpload()#33795Also the new call to
uploadFileWithHeaders()needs to pass$noOfChunksHow Has This Been Tested?
CI
Types of changes
Checklist:
Open tasks: