Skip to content

pause upload to prevent files with same etag#33795

Merged
individual-it merged 1 commit into
masterfrom
pauseUploadApiTests
Dec 7, 2018
Merged

pause upload to prevent files with same etag#33795
individual-it merged 1 commit into
masterfrom
pauseUploadApiTests

Conversation

@individual-it

@individual-it individual-it commented Dec 7, 2018

Copy link
Copy Markdown
Member

Description

uploading too fast during the tests might result in files with the same etag

Related Issue

Motivation and Context

see issue

How Has This Been Tested?

🤖

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • Backport (if applicable set "backport-request" label and remove when the backport was done)

@phil-davis phil-davis left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: the duplication of places where pauseUpload() needs to be called and lastUploadTime needs to be set will be addressed in issue #33690 which already mentions closely-related stuff like makeDavRequest method.

@individual-it

Copy link
Copy Markdown
Member Author

backport in #33796

@codecov

codecov Bot commented Dec 7, 2018

Copy link
Copy Markdown

Codecov Report

Merging #33795 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #33795   +/-   ##
=========================================
  Coverage     64.35%   64.35%           
  Complexity    18309    18309           
=========================================
  Files          1195     1195           
  Lines         69255    69255           
  Branches       1276     1276           
=========================================
  Hits          44566    44566           
  Misses        24317    24317           
  Partials        372      372
Flag Coverage Δ Complexity Δ
#javascript 52.98% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 65.66% <ø> (ø) 18309 <ø> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b80c45a...459b395. Read the comment docs.

1 similar comment
@codecov

codecov Bot commented Dec 7, 2018

Copy link
Copy Markdown

Codecov Report

Merging #33795 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #33795   +/-   ##
=========================================
  Coverage     64.35%   64.35%           
  Complexity    18309    18309           
=========================================
  Files          1195     1195           
  Lines         69255    69255           
  Branches       1276     1276           
=========================================
  Hits          44566    44566           
  Misses        24317    24317           
  Partials        372      372
Flag Coverage Δ Complexity Δ
#javascript 52.98% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 65.66% <ø> (ø) 18309 <ø> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b80c45a...459b395. Read the comment docs.

@individual-it individual-it merged commit 9dca1c3 into master Dec 7, 2018
@delete-merged-branch delete-merged-branch Bot deleted the pauseUploadApiTests branch December 7, 2018 04:10
@lock lock Bot locked as resolved and limited conversation to collaborators Dec 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fileVersion failure in apiMain on master and stable10

2 participants