Skip to content

Improve Drone caching#34700

Merged
PVince81 merged 3 commits into
masterfrom
drone_caching
Mar 7, 2019
Merged

Improve Drone caching#34700
PVince81 merged 3 commits into
masterfrom
drone_caching

Conversation

@patrickjahns

@patrickjahns patrickjahns commented Mar 6, 2019

Copy link
Copy Markdown
Contributor

Description

Currently we are caching the final folders of dependecy managers ( yarn/bower/composer) which has lead to some issues in the past.

This PR attempts to utilize the "cache folders" of the respective dependency managers instead, so the normal install routine is triggered and they are always freshly installed in the final folders

Related Issue

#34435

Motivation and Context

solve #34435

How Has This Been Tested?

🤖

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • purge the cache on minio before merging and add the restore section again
  • Backport (if applicable set "backport-request" label and remove when the backport was done)

@codecov

codecov Bot commented Mar 7, 2019

Copy link
Copy Markdown

Codecov Report

Merging #34700 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #34700   +/-   ##
=========================================
  Coverage     65.28%   65.28%           
  Complexity    18481    18481           
=========================================
  Files          1210     1210           
  Lines         69984    69984           
  Branches       1280     1280           
=========================================
  Hits          45688    45688           
  Misses        23924    23924           
  Partials        372      372
Flag Coverage Δ Complexity Δ
#javascript 53.04% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 66.68% <ø> (ø) 18481 <ø> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bb21e34...47795fc. Read the comment docs.

@patrickjahns
patrickjahns marked this pull request as ready for review March 7, 2019 09:02
@codecov

codecov Bot commented Mar 7, 2019

Copy link
Copy Markdown

Codecov Report

Merging #34700 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #34700   +/-   ##
=========================================
  Coverage     65.28%   65.28%           
  Complexity    18481    18481           
=========================================
  Files          1210     1210           
  Lines         69984    69984           
  Branches       1280     1280           
=========================================
  Hits          45688    45688           
  Misses        23924    23924           
  Partials        372      372
Flag Coverage Δ Complexity Δ
#javascript 53.04% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 66.68% <ø> (ø) 18481 <ø> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bb21e34...ea93e8a. Read the comment docs.

@patrickjahns

Copy link
Copy Markdown
Contributor Author

@phil-davis @PVince81 - this is ready - we need to merge this before any other PRs on core have been merged ( or I need to purge the cache in minio again )

@PVince81
PVince81 merged commit ecdaeb0 into master Mar 7, 2019
@delete-merged-branch
delete-merged-branch Bot deleted the drone_caching branch March 7, 2019 11:49
@PVince81

PVince81 commented Mar 7, 2019

Copy link
Copy Markdown
Contributor

@patrickjahns please backport to stable10

@phil-davis

Copy link
Copy Markdown
Contributor

Backport stable10 #34717
(and that has been cherry-picked into #34698 - "drop PHP 5.6 support" - both changes might be merged together)

@lock lock Bot locked as resolved and limited conversation to collaborators Mar 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants