[Stable10] imrpove drone cache#34717
Closed
patrickjahns wants to merge 3 commits into
Closed
Conversation
Signed-off-by: Patrick Jahns <github@patrickjahns.de>
Signed-off-by: Patrick Jahns <github@patrickjahns.de>
phil-davis
approved these changes
Mar 8, 2019
phil-davis
left a comment
phil-davis
left a comment
Contributor
There was a problem hiding this comment.
Note: 2 lines less diff because the PR in master had some extra blank lines on the end of .gitignore
Contributor
Author
|
Fails now on I wanted to avoid to sprinkel all steps with potential composer pulls to have: Additionally it would have introduced complexity for building the cache in a single iteration |
This was referenced Mar 11, 2019
Merged
Contributor
|
commits have been cherry-picked into PR #34698 and that has been merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #34700
I've already purged the cache on minio - so this will come in clean