allow users to opt-out autocomplete in share dialog

[karakayasemi]

Description

allow users to opt-out autocomplete in sharing dialog

Also, I made some changes to simplify adding a new config option to personal sharing panel.

Related Issue

https://github.com/owncloud/enterprise/issues/3142

Motivation and Context

some users do not want to be found via autocomplete

How Has This Been Tested?

Manually tested by applying the following steps:

• Create a user test
• Login with admin
• Enable Allow username autocompletion in share dialog checkbox within the sharing admin panel
• Login with test
• Disable Allow finding you via autocomplete in share dialog from personal sharing panel with test user
• As an admin, search tes keyword in share dialog, test should not be listed
• Enable Allow finding you via autocomplete in share dialog from personal sharing panel with test user
• As an admin, search tes keyword in share dialog, test should be listed

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Database schema changes (next release will require increase of minor version instead of patch)
• Breaking change (fix or feature that would cause existing functionality to change)
• Technical debt
• Tests only (no source changes)

Checklist:

• Code changes
• Unit tests added
• Acceptance tests added
• Documentation ticket raised:

Open tasks:

• Backport (if applicable set "backport-request" label and remove when the backport was done)

[codecov]

Codecov Report

Merging #34862 into master will decrease coverage by 16.95%.
The diff coverage is n/a.

@@              Coverage Diff              @@
##             master   #34862       +/-   ##
=============================================
- Coverage     65.35%   48.39%   -16.96%     
=============================================
  Files          1208      109     -1099     
  Lines         69969    10493    -59476     
  Branches       1280     1280               
=============================================
- Hits          45726     5078    -40648     
+ Misses        23871     5043    -18828     
  Partials        372      372

Flag	Coverage Δ	Complexity Δ
#javascript	53.04% <ø> (ø)	0 <ø> (ø)	⬇️
#phpunit	38.17% <ø> (-28.59%)	0 <ø> (-18484)

Impacted Files	Coverage Δ	Complexity Δ
lib/private/Files/Storage/DAV.php	59.45% <0%> (-21.64%)	0% <0%> (ø)
apps/updatenotification/templates/admin.php
lib/private/Encryption/Keys/Storage.php
lib/private/App/CodeChecker/NodeVisitor.php
lib/private/RedisFactory.php
apps/dav/lib/Avatars/AvatarNode.php
...s/dav/appinfo/Migrations/Version20170202213905.php
apps/dav/lib/Upload/ChunkLocationProvider.php
apps/files/lib/AppInfo/Application.php
apps/systemtags/list.php
... and 1087 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dad2d30...5fe2a7d. Read the comment docs.

[codecov]

Codecov Report

Merging #34862 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@             Coverage Diff              @@
##             master   #34862      +/-   ##
============================================
+ Coverage     65.34%   65.35%   +<.01%     
- Complexity    18506    18508       +2     
============================================
  Files          1209     1209              
  Lines         70102    70107       +5     
  Branches       1280     1280              
============================================
+ Hits          45806    45815       +9     
+ Misses        23924    23920       -4     
  Partials        372      372

Flag	Coverage Δ	Complexity Δ
#javascript	53.04% <ø> (ø)	0 <ø> (ø)	⬇️
#phpunit	66.76% <100%> (ø)	18508 <0> (+2)	⬆️

Impacted Files	Coverage Δ	Complexity Δ
apps/files_sharing/templates/settings-personal.php	100% <ø> (+80%)	0 <0> (ø)	⬇️
...files_sharing/lib/Controller/ShareesController.php	89.57% <100%> (+0.24%)	106 <0> (+1)	⬆️
...ring/lib/Controller/PersonalSettingsController.php	100% <100%> (ø)	10 <0> (ø)	⬇️
...iles_sharing/lib/Panels/Personal/PersonalPanel.php	100% <100%> (ø)	7 <0> (+1)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f5a4932...71597c6. Read the comment docs.

[karakayasemi]

@jvillafanez you already reviewed similar things in auto-accept share and I believe, you are familiar with code base of this PR. Your review in here can help me. Thanks.

[jvillafanez]

I haven't checked the logic in depth, nor tested it. The code looks fine, just minor touches.

[karakayasemi]

@ownclouders rebase

[ownclouders]

Hey! I'm GitMate.io! This pull request is being rebased automatically. Please DO NOT push while rebase is in progress or your changes would be lost permanently ⚠️

[ownclouders]

Automated rebase with GitMate.io was successful! 🎉

[PVince81]

@karakayasemi please use p() for proper sanitization

[PVince81]

👍