[stable10] allow users to opt-out autocomplete in share dialog#34942
Merged
Conversation
jvillafanez
approved these changes
Apr 3, 2019
This was referenced Apr 15, 2019
11 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #34862
Description
allow users to opt-out autocomplete in sharing dialog
Also, I made some changes to simplify adding a new config option to personal sharing panel.
Related Issue
https://github.com/owncloud/enterprise/issues/3142
Motivation and Context
some users do not want to be found via autocomplete
How Has This Been Tested?
Manually tested by applying the following steps:
testadminAllow username autocompletion in share dialogcheckbox within the sharing admin paneltestAllow finding you via autocomplete in share dialogfrom personal sharing panel withtestuserteskeyword in share dialog,testshould not be listedAllow finding you via autocomplete in share dialogfrom personal sharing panel withtestuserteskeyword in share dialog,testshould be listedTypes of changes
Checklist: